Only block http or https doc.written scripts.

Only block http or https doc.written scripts.

The current implementation will return true, indicating that the fetch should
be blocked, for any script with a 'src' attribute. This includes file: and data:
among others. We only want to block resources loaded from network, so we restrict
to http and https scripts.

This change doesn't include tests, since there isn't actually any behavior change
here that I can detect. Even though shouldDisallow will return true for data: URLs,
the script will continue to execute. However, it's useful for us to return false
in the blocking method, since that allows us to avoid having the
didObserveLoadingBehavior method get called, which could cause our metrics to be
incorrect.

BUG=616312
Committed: https://crrev.com/96268153217282dfd921387cb033f83e7f583d60
Cr-Commit-Position: refs/heads/master@{#397419}

[Bryan McQuade, 2016-06-01 00:06:40]

Description was changed from

==========
Only block http or https doc.written scripts.

BUG=
==========

to

==========
Only block http or https doc.written scripts.

The current implementation will return true, indicating that the fetch should
be blocked, for any script with a 'src' attribute. This includes file: and data:
among others. We only want to block resources loaded from network, so we
restrict
to http and https scripts.

BUG=
==========

[Bryan McQuade, 2016-06-01 00:07:49]

Description was changed from

==========
Only block http or https doc.written scripts.

The current implementation will return true, indicating that the fetch should
be blocked, for any script with a 'src' attribute. This includes file: and data:
among others. We only want to block resources loaded from network, so we
restrict
to http and https scripts.

BUG=
==========

to

==========
Only block http or https doc.written scripts.

The current implementation will return true, indicating that the fetch should
be blocked, for any script with a 'src' attribute. This includes file: and data:
among others. We only want to block resources loaded from network, so we
restrict
to http and https scripts.

BUG=616312
==========

[Bryan McQuade, 2016-06-01 00:11:08]

Description was changed from

==========
Only block http or https doc.written scripts.

The current implementation will return true, indicating that the fetch should
be blocked, for any script with a 'src' attribute. This includes file: and data:
among others. We only want to block resources loaded from network, so we
restrict
to http and https scripts.

BUG=616312
==========

to

==========
Only block http or https doc.written scripts.

The current implementation will return true, indicating that the fetch should
be blocked, for any script with a 'src' attribute. This includes file: and data:
among others. We only want to block resources loaded from network, so we
restrict
to http and https scripts.

This change doesn't include tests, since there isn't actually any behavior
change
here that I can detect. Even though shouldDisallow will return true for data:
URLs,
the script will continue to execute. However, it's useful for us to return false
in the blocking method, since that allows us to avoid having the
didObserveLoadingBehavior method get called, which could cause our metrics to be
incorrect.

BUG=616312
==========

[Bryan McQuade, 2016-06-01 00:11:19]

Description was changed from

==========
Only block http or https doc.written scripts.

The current implementation will return true, indicating that the fetch should
be blocked, for any script with a 'src' attribute. This includes file: and data:
among others. We only want to block resources loaded from network, so we
restrict
to http and https scripts.

This change doesn't include tests, since there isn't actually any behavior
change
here that I can detect. Even though shouldDisallow will return true for data:
URLs,
the script will continue to execute. However, it's useful for us to return false
in the blocking method, since that allows us to avoid having the
didObserveLoadingBehavior method get called, which could cause our metrics to be
incorrect.

BUG=616312
==========

to

==========
Only block http or https doc.written scripts.

The current implementation will return true, indicating that the fetch should
be blocked, for any script with a 'src' attribute. This includes file: and data:
among others. We only want to block resources loaded from network, so we
restrict
to http and https scripts.

This change doesn't include tests, since there isn't actually any behavior
change
here that I can detect. Even though shouldDisallow will return true for data:
URLs,
the script will continue to execute. However, it's useful for us to return false
in the blocking method, since that allows us to avoid having the
didObserveLoadingBehavior method get called, which could cause our metrics to be
incorrect.

BUG=616312
==========

[Bryan McQuade, 2016-06-01 12:05:47]

bmcquade@chromium.org changed reviewers:
+ shivanisha@chromium.org

[shivanisha, 2016-06-01 14:10:48]

On 2016/06/01 at 12:05:52, bmcquade wrote:
> 

LGTM. Thanks for this change!

[Bryan McQuade, 2016-06-01 14:31:15]

bmcquade@chromium.org changed reviewers:
+ csharrison@chromium.org

[Bryan McQuade, 2016-06-01 14:31:26]

Adding csharrison for owners/committer review.

[Yoav Weiss, 2016-06-01 14:35:07]

On 2016/06/01 14:31:26, Bryan McQuade wrote:
> Adding csharrison for owners/committer review.

I'm no csharrison, but LGTM :)

[Bryan McQuade, 2016-06-01 14:35:53]

Thanks Yoav!

On Wed, Jun 1, 2016 at 10:35 AM <yoav@yoav.ws> wrote:

> On 2016/06/01 14:31:26, Bryan McQuade wrote:
> > Adding csharrison for owners/committer review.
>
> I'm no csharrison, but LGTM :)
>
> https://codereview.chromium.org/2026983002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Bryan McQuade, 2016-06-01 14:35:54]

Thanks Yoav!

On Wed, Jun 1, 2016 at 10:35 AM <yoav@yoav.ws> wrote:

> On 2016/06/01 14:31:26, Bryan McQuade wrote:
> > Adding csharrison for owners/committer review.
>
> I'm no csharrison, but LGTM :)
>
> https://codereview.chromium.org/2026983002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Charlie Harrison, 2016-06-02 13:33:49]

Sorry for the delay, LGTM.

[Charlie Harrison, 2016-06-02 13:34:23]

I'm also no OWNER of this code :)

[Bryan McQuade, 2016-06-02 13:36:54]

The CQ bit was checked by bmcquade@chromium.org

[commit-bot: I haz the power, 2016-06-02 13:37:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2026983002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2026983002/1

[commit-bot: I haz the power, 2016-06-02 15:40:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-02 15:41:32]

Description was changed from

==========
Only block http or https doc.written scripts.

The current implementation will return true, indicating that the fetch should
be blocked, for any script with a 'src' attribute. This includes file: and data:
among others. We only want to block resources loaded from network, so we
restrict
to http and https scripts.

This change doesn't include tests, since there isn't actually any behavior
change
here that I can detect. Even though shouldDisallow will return true for data:
URLs,
the script will continue to execute. However, it's useful for us to return false
in the blocking method, since that allows us to avoid having the
didObserveLoadingBehavior method get called, which could cause our metrics to be
incorrect.

BUG=616312
==========

to

==========
Only block http or https doc.written scripts.

The current implementation will return true, indicating that the fetch should
be blocked, for any script with a 'src' attribute. This includes file: and data:
among others. We only want to block resources loaded from network, so we
restrict
to http and https scripts.

This change doesn't include tests, since there isn't actually any behavior
change
here that I can detect. Even though shouldDisallow will return true for data:
URLs,
the script will continue to execute. However, it's useful for us to return false
in the blocking method, since that allows us to avoid having the
didObserveLoadingBehavior method get called, which could cause our metrics to be
incorrect.

BUG=616312

Committed: https://crrev.com/96268153217282dfd921387cb033f83e7f583d60
Cr-Commit-Position: refs/heads/master@{#397419}
==========

[commit-bot: I haz the power, 2016-06-02 15:41:33]

Patchset 1 (id:??) landed as
https://crrev.com/96268153217282dfd921387cb033f83e7f583d60
Cr-Commit-Position: refs/heads/master@{#397419}