Disable external navigation for file downloads.

Disable external navigation for file downloads.

Allow Chrome to handle downloads, otherwise the user may end up in a
situation where an external application is handling the download, but
doesn't have credentials to do so.

Tying this to SystemDownloadManager feature -- we should only be doing
this when Chrome is handling downloads.

BUG=605302
Committed: https://crrev.com/c69dcd0656f7f5dd570ca55c46393f79d3fc1368
Cr-Commit-Position: refs/heads/master@{#397255}

[Maria, 2016-05-31 22:03:24]

mariakhomenko@chromium.org changed reviewers:
+ qinmin@chromium.org

[qinmin, 2016-06-01 16:45:41]

For media Mime type, even if the format is not supported by chrome, we should
still pass the url to external app rather than download it. 
For example, Chrome is not able to play rtsp streams, but android gallery app
can. Downloading a video/audio is not desirable.

[chromium-reviews, 2016-06-01 17:02:48]

Why wouldn't we want to do the download in Chrome and then pass it to
gallery app after it's downloaded? Wouldn't the same argument about
credentials apply?

On Wed, Jun 1, 2016 at 9:45 AM <qinmin@chromium.org> wrote:

> For media Mime type, even if the format is not supported by chrome, we
> should
> still pass the url to external app rather than download it.
> For example, Chrome is not able to play rtsp streams, but android gallery
> app
> can. Downloading a video/audio is not desirable.
>
> https://codereview.chromium.org/2026953002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[qinmin, 2016-06-01 17:09:40]

On 2016/06/01 17:02:48, chromium-reviews wrote:
> Why wouldn't we want to do the download in Chrome and then pass it to
> gallery app after it's downloaded? Wouldn't the same argument about
> credentials apply?

Media types could be a live stream, so there is no way to download them. Also,
downloading a media file means user cannot perform operations like seek to
reduce data consumption.

> 
> On Wed, Jun 1, 2016 at 9:45 AM <mailto:qinmin@chromium.org> wrote:
> 
> > For media Mime type, even if the format is not supported by chrome, we
> > should
> > still pass the url to external app rather than download it.
> > For example, Chrome is not able to play rtsp streams, but android gallery
> > app
> > can. Downloading a video/audio is not desirable.
> >
> > https://codereview.chromium.org/2026953002/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[Maria, 2016-06-01 18:42:42]

On 2016/06/01 17:09:40, qinmin wrote:
> On 2016/06/01 17:02:48, chromium-reviews wrote:
> > Why wouldn't we want to do the download in Chrome and then pass it to
> > gallery app after it's downloaded? Wouldn't the same argument about
> > credentials apply?
> 
> Media types could be a live stream, so there is no way to download them. Also,
> downloading a media file means user cannot perform operations like seek to
> reduce data consumption.
> 
> > 
> > On Wed, Jun 1, 2016 at 9:45 AM <mailto:qinmin@chromium.org> wrote:
> > 
> > > For media Mime type, even if the format is not supported by chrome, we
> > > should
> > > still pass the url to external app rather than download it.
> > > For example, Chrome is not able to play rtsp streams, but android gallery
> > > app
> > > can. Downloading a video/audio is not desirable.
> > >
> > > https://codereview.chromium.org/2026953002/
> > >
> > 
> > -- 
> > You received this message because you are subscribed to the Google Groups
> > "Chromium-reviews" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> email
> > to mailto:chromium-reviews+unsubscribe@chromium.org.

Changed to only force .pdf files to download since it's difficult to distinguish
streamable files from downloadable content as per in-person discussion.

[qinmin, 2016-06-01 18:49:35]

lgtm

[Maria, 2016-06-01 18:53:58]

The CQ bit was checked by mariakhomenko@chromium.org

[commit-bot: I haz the power, 2016-06-01 18:54:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2026953002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2026953002/40001

[commit-bot: I haz the power, 2016-06-01 20:14:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-01 20:14:52]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Maria, 2016-06-01 20:33:38]

The CQ bit was checked by mariakhomenko@chromium.org

[Maria, 2016-06-01 20:33:39]

The patchset sent to the CQ was uploaded after l-g-t-m from qinmin@chromium.org
Link to the patchset: https://codereview.chromium.org/2026953002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-06-01 20:34:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2026953002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2026953002/60001

[commit-bot: I haz the power, 2016-06-01 21:36:16]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-01 21:37:18]

Description was changed from

==========
Disable external navigation for file downloads.

Allow Chrome to handle downloads, otherwise the user may end up in a
situation where an external application is handling the download, but
doesn't have credentials to do so.

Tying this to SystemDownloadManager feature -- we should only be doing
this when Chrome is handling downloads.

BUG=605302
==========

to

==========
Disable external navigation for file downloads.

Allow Chrome to handle downloads, otherwise the user may end up in a
situation where an external application is handling the download, but
doesn't have credentials to do so.

Tying this to SystemDownloadManager feature -- we should only be doing
this when Chrome is handling downloads.

BUG=605302

Committed: https://crrev.com/c69dcd0656f7f5dd570ca55c46393f79d3fc1368
Cr-Commit-Position: refs/heads/master@{#397255}
==========

[commit-bot: I haz the power, 2016-06-01 21:37:19]

Patchset 4 (id:??) landed as
https://crrev.com/c69dcd0656f7f5dd570ca55c46393f79d3fc1368
Cr-Commit-Position: refs/heads/master@{#397255}