fpdfsdk/jsapi/fxjs_v8_embeddertest.cpp - Issue 2026933002: Remove use of v8:Lockers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/jsapi/fxjs_v8_embeddertest.cpp

Issue 2026933002: Remove use of v8:Lockers (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/jsapi/fxjs_v8_embeddertest.cpp

diff --git a/fpdfsdk/jsapi/fxjs_v8_embeddertest.cpp b/fpdfsdk/jsapi/fxjs_v8_embeddertest.cpp

index e89bb28113b7bc463d3bcc51257aa5a4025043f8..161487f356f89255048c88801858c5f8c6921050 100644

--- a/fpdfsdk/jsapi/fxjs_v8_embeddertest.cpp

+++ b/fpdfsdk/jsapi/fxjs_v8_embeddertest.cpp

@@ -36,9 +36,6 @@ class FXJSV8EmbedderTest : public JSEmbedderTest {

TEST_F(FXJSV8EmbedderTest, Getters) {

v8::Isolate::Scope isolate_scope(isolate());

-#ifdef PDF_ENABLE_XFA

- v8::Locker locker(isolate());

-#endif // PDF_ENABLE_XFA

v8::HandleScope handle_scope(isolate());

v8::Context::Scope context_scope(GetV8Context());

@@ -48,9 +45,6 @@ TEST_F(FXJSV8EmbedderTest, Getters) {

TEST_F(FXJSV8EmbedderTest, MultipleRutimes) {

v8::Isolate::Scope isolate_scope(isolate());

-#ifdef PDF_ENABLE_XFA

- v8::Locker locker(isolate());

-#endif // PDF_ENABLE_XFA

v8::HandleScope handle_scope(isolate());

v8::Global<v8::Context> global_context1;

« no previous file with comments | « fpdfsdk/jsapi/fxjs_v8.cpp ('k') | testing/js_embedder_test.cpp » ('j') | no next file with comments »