Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2026933002: Remove use of v8:Lockers (Closed)

Created:
4 years, 6 months ago by Tom Sepez
Modified:
4 years, 6 months ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove use of v8:Lockers The entire code base is single-threaded, hence the lockers ought not be required. Committed: https://pdfium.googlesource.com/pdfium/+/8abd7a2bbfef51ca6dc8a3462c067e5d2c46200e

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -41 lines) Patch
M fpdfsdk/javascript/cjs_context.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M fpdfsdk/javascript/cjs_runtime.cpp View 5 chunks +0 lines, -9 lines 0 comments Download
M fpdfsdk/javascript/public_methods_embeddertest.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M fpdfsdk/jsapi/fxjs_v8.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M fpdfsdk/jsapi/fxjs_v8_embeddertest.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M testing/js_embedder_test.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fxjse/runtime.cpp View 1 chunk +3 lines, -6 lines 0 comments Download
M xfa/fxjse/scope_inline.h View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Jochen, for review. Lei, fyi.
4 years, 6 months ago (2016-05-31 21:49:47 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 6 months ago (2016-06-01 15:06:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026933002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026933002/20001
4 years, 6 months ago (2016-06-01 20:25:43 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 20:35:32 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/8abd7a2bbfef51ca6dc8a3462c067e5d2c46...

Powered by Google App Engine
This is Rietveld 408576698