components/offline_pages/offline_page_model_impl.h - Issue 2026843003: [Offline Pages] Removing client in storage manager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/offline_page_model_impl.h

Issue 2026843003: [Offline Pages] Removing client in storage manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/offline_pages/offline_page_model.h ('K') | « components/offline_pages/offline_page_model.h ('k') | components/offline_pages/offline_page_storage_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/offline_page_model_impl.h

diff --git a/components/offline_pages/offline_page_model_impl.h b/components/offline_pages/offline_page_model_impl.h

index b32798ba3bc78347f34fff43bb72cc69f98aa9fe..c6c9c2f578507a01e4b62af1dee629c4f46be247 100644

--- a/components/offline_pages/offline_page_model_impl.h

+++ b/components/offline_pages/offline_page_model_impl.h

@@ -67,9 +67,9 @@ class OfflinePageModelImpl : public OfflinePageModel, public KeyedService {

std::unique_ptr<OfflinePageArchiver> archiver,

const SavePageCallback& callback) override;

void MarkPageAccessed(int64_t offline_id) override;

+ void ClearAll(const base::Closure& callback) override;

void DeletePagesByOfflineId(const std::vector<int64_t>& offline_ids,

const DeletePageCallback& callback) override;

- void ClearAll(const base::Closure& callback) override;

void DeletePagesByURLPredicate(const UrlPredicate& predicate,

const DeletePageCallback& callback) override;

void HasPages(const std::string& name_space,