MD - update checkbox and radio buttons

MD - update checkbox and radio buttons

TODO: ripples
TODO: animating between states

BUG=609922
Committed: https://crrev.com/104196ecfadb1982e093752f6b01248b6448157a
Cr-Commit-Position: refs/heads/master@{#397289}

[Evan Stade, 2016-05-31 23:57:57]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Evan Stade, 2016-05-31 23:58:05]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[commit-bot: I haz the power, 2016-05-31 23:58:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2026833003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2026833003/1

[commit-bot: I haz the power, 2016-06-01 01:43:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-01 01:43:51]

Dry run: This issue passed the CQ dry run.

[sky, 2016-06-01 03:28:23]

LGTM

https://codereview.chromium.org/2026833003/diff/1/ui/gfx/vector_icons/checkbo...
File ui/gfx/vector_icons/checkbox_active.icon (right):

https://codereview.chromium.org/2026833003/diff/1/ui/gfx/vector_icons/checkbo...
ui/gfx/vector_icons/checkbox_active.icon:1: // Copyright 2015 The Chromium
Authors. All rights reserved.
nit: 2016 on these

https://codereview.chromium.org/2026833003/diff/1/ui/views/controls/button/ch...
File ui/views/controls/button/checkbox.cc (right):

https://codereview.chromium.org/2026833003/diff/1/ui/views/controls/button/ch...
ui/views/controls/button/checkbox.cc:39: set_request_focus_on_press(false);
I didn't realize we were changing behavior too. Interesting.

https://codereview.chromium.org/2026833003/diff/1/ui/views/controls/button/ch...
File ui/views/controls/button/checkbox.h (right):

https://codereview.chromium.org/2026833003/diff/1/ui/views/controls/button/ch...
ui/views/controls/button/checkbox.h:25: static bool UseMd();
Move to protected section as only subclasses should care?

[Evan Stade, 2016-06-01 21:01:11]

https://codereview.chromium.org/2026833003/diff/1/ui/gfx/vector_icons/checkbo...
File ui/gfx/vector_icons/checkbox_active.icon (right):

https://codereview.chromium.org/2026833003/diff/1/ui/gfx/vector_icons/checkbo...
ui/gfx/vector_icons/checkbox_active.icon:1: // Copyright 2015 The Chromium
Authors. All rights reserved.
On 2016/06/01 03:28:23, sky wrote:
> nit: 2016 on these

Done.

https://codereview.chromium.org/2026833003/diff/1/ui/views/controls/button/ch...
File ui/views/controls/button/checkbox.cc (right):

https://codereview.chromium.org/2026833003/diff/1/ui/views/controls/button/ch...
ui/views/controls/button/checkbox.cc:39: set_request_focus_on_press(false);
On 2016/06/01 03:28:23, sky wrote:
> I didn't realize we were changing behavior too. Interesting.

I'll double check with Sebastien but AFAIU we don't want to show focus rings due
to mouse press.

https://codereview.chromium.org/2026833003/diff/1/ui/views/controls/button/ch...
File ui/views/controls/button/checkbox.h (right):

https://codereview.chromium.org/2026833003/diff/1/ui/views/controls/button/ch...
ui/views/controls/button/checkbox.h:25: static bool UseMd();
On 2016/06/01 03:28:23, sky wrote:
> Move to protected section as only subclasses should care?

Done.

[Evan Stade, 2016-06-01 21:01:40]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-06-01 21:01:41]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2026833003/#ps20001
(title: "sky review")

[commit-bot: I haz the power, 2016-06-01 21:03:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2026833003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2026833003/20001

[commit-bot: I haz the power, 2016-06-01 23:53:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-01 23:53:48]

Try jobs failed on following builders:
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[Evan Stade, 2016-06-02 00:05:42]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-06-02 00:06:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2026833003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2026833003/20001

[commit-bot: I haz the power, 2016-06-02 01:38:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-02 01:39:37]

Description was changed from

==========
MD - update checkbox and radio buttons

TODO: ripples
TODO: animating between states

BUG=609922
==========

to

==========
MD - update checkbox and radio buttons

TODO: ripples
TODO: animating between states

BUG=609922

Committed: https://crrev.com/104196ecfadb1982e093752f6b01248b6448157a
Cr-Commit-Position: refs/heads/master@{#397289}
==========

[commit-bot: I haz the power, 2016-06-02 01:39:38]

Patchset 2 (id:??) landed as
https://crrev.com/104196ecfadb1982e093752f6b01248b6448157a
Cr-Commit-Position: refs/heads/master@{#397289}