Fix always_inline warning in libpjeg_turbo

Fix always_inline warning in libpjeg_turbo

"__attribute__((always_inline))" does not replace "inline" and they
still need to be used together. This fixes "always_inline function
might not be inlinable [-Wattributes]" warning in gcc 4.7.

BUG= warnings in Chromium build

[petarj, 2014-03-18 13:24:57]

Fix always_inline warning in libpjeg_turbo

"__attribute__((always_inline))" does not replace "inline" and they
still need to be used together. This fixes "always_inline function
might not be inlinable [-Wattributes]" warning in gcc 4.7.


After the following CL,

https://codereview.chromium.org/196943020/

all POSIX platforms should fail to link if they use 4.7 or newer GCC.

Here it is in MIPS case:

http://www.rt-rk.com/mips-buildbot/builders/build_and_test_chromium_trunk_for...

[petarj, 2014-03-18 13:32:28]

On 2014/03/18 13:24:57, petarj wrote:
> Here it is in MIPS case:

Correct link is:

http://www.rt-rk.com/mips-buildbot/builders/build_and_test_chromium_trunk_for...

[petarj, 2014-03-18 15:28:28]

On 2014/03/18 13:24:57, petarj wrote:
> After the following CL,
> 
> https://codereview.chromium.org/196943020/
>

Please ignore this part of my first comment (#1), it seems multiple issues are
tight together.
Treat this CL as a change to fix warnings with gcc 4.7.x.

[petarj, 2014-03-18 15:57:30]

Patch to upstream has just been sent:

http://sourceforge.net/p/libjpeg-turbo/patches/56/

[Xianzhu, 2014-03-18 16:20:49]

We should try to avoid modify files locally in downstream. At least we should
mention it in README.chromium. Perhaps it's better to modify libjpeg.gyp (which
is a pure downstream file) before we get the upstream version, or just wait for
upstream commit and then update.

[petarj, 2014-03-18 16:47:16]

On 2014/03/18 16:20:49, Xianzhu wrote:
> We should try to avoid modify files locally in downstream. At least we should
> mention it in README.chromium. Perhaps it's better to modify libjpeg.gyp
(which
> is a pure downstream file) before we get the upstream version, or just wait
for
> upstream commit and then update.

Ok, let's wait till this gets accepted upstream first.
Thanks.

[petarj, 2014-03-18 16:47:40]

On 2014/03/18 16:47:16, petarj wrote:
> On 2014/03/18 16:20:49, Xianzhu wrote:
> > We should try to avoid modify files locally in downstream. At least we
should
> > mention it in README.chromium. Perhaps it's better to modify libjpeg.gyp
> (which
> > is a pure downstream file) before we get the upstream version, or just wait
> for
> > upstream commit and then update.
> 
> Ok, let's wait till this gets accepted upstream first.
> Thanks.

Closing the issue.

[earthdok, 2014-03-18 16:47:57]

On 2014/03/18 16:20:49, Xianzhu wrote:
> We should try to avoid modify files locally in downstream. At least we should
> mention it in README.chromium. Perhaps it's better to modify libjpeg.gyp
(which
> is a pure downstream file) before we get the upstream version, or just wait
for
> upstream commit and then update.

I'm confused as to why you added me as a reviewer.

[Xianzhu, 2014-03-18 17:13:38]

On 2014/03/18 16:47:57, earthdok wrote:
> On 2014/03/18 16:20:49, Xianzhu wrote:
> > We should try to avoid modify files locally in downstream. At least we
should
> > mention it in README.chromium. Perhaps it's better to modify libjpeg.gyp
> (which
> > is a pure downstream file) before we get the upstream version, or just wait
> for
> > upstream commit and then update.
> 
> I'm confused as to why you added me as a reviewer.

There is no OWNERS file under third_party/libjpeg_turbo. Found you from git log,
just like how petarj found me. Just hoped you might know more about the
directory :)

[Noel Gordon, 2014-03-19 00:51:53]

I was added also, and that's fine.  

> Ok, let's wait till this gets accepted upstream first.

That'd be best, thanks.

[petarj, 2014-03-21 12:22:19]

On 2014/03/19 00:51:53, Noel Gordon (Google) wrote:
> I was added also, and that's fine.  
> 
> > Ok, let's wait till this gets accepted upstream first.
> 
> That'd be best, thanks.

Just for the record, this has just been accepted upstream as:
http://sourceforge.net/p/libjpeg-turbo/code/1188/