Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 202683004: Revert 257505 "Adds the ability for the renderer to create the m..." (Closed)

Created:
6 years, 9 months ago by viettrungluu
Modified:
6 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 257505 "Adds the ability for the renderer to create the m..." [Broke Linux Official builds -- packaging stuff. mojo_system.so needs to be added to some list(s) somewhere, I think.] > Adds the ability for the renderer to create the mojo channel > > This is initiated and owned by RenderProcessHost. I've added a > method to RenderProcessHostImpl to create the channel. No one is > calling it yet, that will come after this. > > RenderProcessHostImpl::CreateMojoChannel initiates the connection and > sends an IPC message to the renderer. The renderer than creates its > end of the connection. > > End to end test will come once I've added all the pieces. > > BUG=none > TEST=none > R=darin@chromium.org, tsepez@chromium.org, viettrungluu@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257342 > > Review URL: https://codereview.chromium.org/195993010 TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257565

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -422 lines) Patch
M trunk/src/content/DEPS View 1 chunk +1 line, -3 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_process_host_impl.h View 3 chunks +3 lines, -11 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_process_host_impl.cc View 5 chunks +3 lines, -44 lines 0 comments Download
M trunk/src/content/common/content_message_generator.h View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/content/common/mojo/OWNERS View 1 chunk +0 lines, -25 lines 0 comments Download
D trunk/src/content/common/mojo/mojo_channel_init.h View 1 chunk +0 lines, -72 lines 0 comments Download
D trunk/src/content/common/mojo/mojo_channel_init.cc View 1 chunk +0 lines, -97 lines 0 comments Download
D trunk/src/content/common/mojo/mojo_messages.h View 1 chunk +0 lines, -22 lines 0 comments Download
M trunk/src/content/content_browser.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
M trunk/src/content/content_common.gypi View 2 chunks +0 lines, -25 lines 0 comments Download
M trunk/src/content/content_renderer.gypi View 2 chunks +1 line, -5 lines 0 comments Download
D trunk/src/content/renderer/mojo/mojo_render_process_observer.h View 1 chunk +0 lines, -48 lines 0 comments Download
D trunk/src/content/renderer/mojo/mojo_render_process_observer.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M trunk/src/content/renderer/render_thread_impl.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M trunk/src/ipc/ipc_message_start.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
viettrungluu
6 years, 9 months ago (2014-03-18 01:06:40 UTC) #1
viettrungluu
6 years, 9 months ago (2014-03-18 01:06:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r257565 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698