gl: Clean up gfx::AcceleratedWidget usage in gl_surface_egl

gl: Clean up gfx::AcceleratedWidget usage in gl_surface_egl

NativeViewGLSurfaceEGL requires a EGLNativeWindowType argument, so make
this explicit. With ozone, we want gfx::AcceleratedWidget to be different
from EGLNativeWindowType, and this prepares for that possibility.

TEST=ui_unittests, content_shell --ozone-platform={file,dri}
BUG=353788
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259090

[rjkroege, 2014-03-20 17:52:04]

https://codereview.chromium.org/202683003/diff/60001/ui/gl/gl_surface_egl.cc
File ui/gl/gl_surface_egl.cc (left):

https://codereview.chromium.org/202683003/diff/60001/ui/gl/gl_surface_egl.cc#...
ui/gl/gl_surface_egl.cc:353: if (window_ == kNullAcceleratedWidget) {
why did you take this out?

https://codereview.chromium.org/202683003/diff/60001/ui/gl/gl_surface_egl.cc
File ui/gl/gl_surface_egl.cc (right):

https://codereview.chromium.org/202683003/diff/60001/ui/gl/gl_surface_egl.cc#...
ui/gl/gl_surface_egl.cc:771: explicit GLSurfaceOSMesaHeadless();
why not EGLNativeWindow?

[spang, 2014-03-20 19:06:44]

https://codereview.chromium.org/202683003/diff/60001/ui/gl/gl_surface_egl.cc
File ui/gl/gl_surface_egl.cc (left):

https://codereview.chromium.org/202683003/diff/60001/ui/gl/gl_surface_egl.cc#...
ui/gl/gl_surface_egl.cc:353: if (window_ == kNullAcceleratedWidget) {
On 2014/03/20 17:52:04, rjkroege wrote:
> why did you take this out?

I don't believe there is a NULL value for EGLNativeWindowType in the spec.

So if we need this check, it has to happen a little bit earlier.

https://codereview.chromium.org/202683003/diff/60001/ui/gl/gl_surface_egl.cc
File ui/gl/gl_surface_egl.cc (right):

https://codereview.chromium.org/202683003/diff/60001/ui/gl/gl_surface_egl.cc#...
ui/gl/gl_surface_egl.cc:771: explicit GLSurfaceOSMesaHeadless();
On 2014/03/20 17:52:04, rjkroege wrote:
> why not EGLNativeWindow?

We could, but why pass a value that is not used?

[rjkroege, 2014-03-24 15:14:03]

On 2014/03/20 19:06:44, spang wrote:
> https://codereview.chromium.org/202683003/diff/60001/ui/gl/gl_surface_egl.cc
> File ui/gl/gl_surface_egl.cc (left):
> 
>
https://codereview.chromium.org/202683003/diff/60001/ui/gl/gl_surface_egl.cc#...
> ui/gl/gl_surface_egl.cc:353: if (window_ == kNullAcceleratedWidget) {
> On 2014/03/20 17:52:04, rjkroege wrote:
> > why did you take this out?
> 
> I don't believe there is a NULL value for EGLNativeWindowType in the spec.

ok. We could ask for one if it would possibly make the code cleaner in the long
term?

> 
> So if we need this check, it has to happen a little bit earlier.
> 
> https://codereview.chromium.org/202683003/diff/60001/ui/gl/gl_surface_egl.cc
> File ui/gl/gl_surface_egl.cc (right):
> 
>
https://codereview.chromium.org/202683003/diff/60001/ui/gl/gl_surface_egl.cc#...
> ui/gl/gl_surface_egl.cc:771: explicit GLSurfaceOSMesaHeadless();
> On 2014/03/20 17:52:04, rjkroege wrote:
> > why not EGLNativeWindow?
> 
> We could, but why pass a value that is not used?

sgtm.

lgtm

[spang, 2014-03-24 16:04:03]

+piman

[piman, 2014-03-24 19:16:24]

lgtm

[spang, 2014-03-24 19:42:03]

The CQ bit was checked by spang@chromium.org

[commit-bot: I haz the power, 2014-03-24 19:43:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/spang@chromium.org/202683003/60001

[commit-bot: I haz the power, 2014-03-24 22:17:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-24 22:17:40]

Retried try job too often on win_rel for step(s) content_browsertests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[spang, 2014-03-24 22:24:01]

The CQ bit was checked by spang@chromium.org

[commit-bot: I haz the power, 2014-03-24 22:26:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/spang@chromium.org/202683003/60001

[commit-bot: I haz the power, 2014-03-25 01:58:34]

Change committed as 259090