Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp

Issue 2026823003: Disable frame navigations during DocumentLoader detach in FrameLoader::startLoad (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Simon Hausmann <hausmann@kde.org> 4 * (C) 2000 Simon Hausmann <hausmann@kde.org>
5 * Copyright (C) 2003, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed. 5 * Copyright (C) 2003, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed.
6 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 6 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 344 matching lines...) Expand 10 before | Expand all | Expand 10 after
355 } else { 355 } else {
356 request.setRequestContext(WebURLRequest::RequestContextHyperlink); 356 request.setRequestContext(WebURLRequest::RequestContextHyperlink);
357 FrameLoadRequest frameRequest(&document(), request, getAttribute(targetA ttr)); 357 FrameLoadRequest frameRequest(&document(), request, getAttribute(targetA ttr));
358 frameRequest.setTriggeringEvent(event); 358 frameRequest.setTriggeringEvent(event);
359 if (hasRel(RelationNoReferrer)) { 359 if (hasRel(RelationNoReferrer)) {
360 frameRequest.setShouldSendReferrer(NeverSendReferrer); 360 frameRequest.setShouldSendReferrer(NeverSendReferrer);
361 frameRequest.setShouldSetOpener(NeverSetOpener); 361 frameRequest.setShouldSetOpener(NeverSetOpener);
362 } 362 }
363 if (hasRel(RelationNoOpener)) 363 if (hasRel(RelationNoOpener))
364 frameRequest.setShouldSetOpener(NeverSetOpener); 364 frameRequest.setShouldSetOpener(NeverSetOpener);
365 // TODO(japhet): Link clicks can be emulated via JS without a user gestu re.
366 // Why doesn't this go through NavigationScheduler?
365 frame->loader().load(frameRequest); 367 frame->loader().load(frameRequest);
366 } 368 }
367 } 369 }
368 370
369 bool isEnterKeyKeydownEvent(Event* event) 371 bool isEnterKeyKeydownEvent(Event* event)
370 { 372 {
371 return event->type() == EventTypeNames::keydown && event->isKeyboardEvent() && toKeyboardEvent(event)->keyIdentifier() == "Enter" && !toKeyboardEvent(event) ->repeat(); 373 return event->type() == EventTypeNames::keydown && event->isKeyboardEvent() && toKeyboardEvent(event)->keyIdentifier() == "Enter" && !toKeyboardEvent(event) ->repeat();
372 } 374 }
373 375
374 bool isLinkClick(Event* event) 376 bool isLinkClick(Event* event)
(...skipping 12 matching lines...) Expand all
387 } 389 }
388 390
389 Node::InsertionNotificationRequest HTMLAnchorElement::insertedInto(ContainerNode * insertionPoint) 391 Node::InsertionNotificationRequest HTMLAnchorElement::insertedInto(ContainerNode * insertionPoint)
390 { 392 {
391 InsertionNotificationRequest request = HTMLElement::insertedInto(insertionPo int); 393 InsertionNotificationRequest request = HTMLElement::insertedInto(insertionPo int);
392 logAddElementIfIsolatedWorldAndInDocument("a", hrefAttr); 394 logAddElementIfIsolatedWorldAndInDocument("a", hrefAttr);
393 return request; 395 return request;
394 } 396 }
395 397
396 } // namespace blink 398 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698