third_party/WebKit/Source/platform/graphics/BitmapImage.h - Issue 2026803002: Avoid GPU readback in tex(Sub)Image2D(ImageBitmap)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/BitmapImage.h

Issue 2026803002: Avoid GPU readback in tex(Sub)Image2D(ImageBitmap) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: should work Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/BitmapImage.h

diff --git a/third_party/WebKit/Source/platform/graphics/BitmapImage.h b/third_party/WebKit/Source/platform/graphics/BitmapImage.h

index c237257adedce8137d641d3cfb2792a54ee9e015..fc6a6f6aa63cf9afa0ca7c80f5b5afd1a3eb5ead 100644

--- a/third_party/WebKit/Source/platform/graphics/BitmapImage.h

+++ b/third_party/WebKit/Source/platform/graphics/BitmapImage.h

@@ -77,7 +77,7 @@ public:

ImageAnimationPolicy animationPolicy() override { return m_animationPolicy; }

void advanceTime(double deltaTimeInSeconds) override;

- PassRefPtr<SkImage> imageForCurrentFrame() override;

+ PassRefPtr<SkImage> imageForCurrentFrame(WebGraphicsContext3DProvider* = nullptr) override;

PassRefPtr<Image> imageForDefaultFrame() override;

bool currentFrameKnownToBeOpaque(MetadataMode = UseCurrentMetadata) override;