Avoid GPU readback in tex(Sub)Image2D(ImageBitmap)

third_party/WebKit/LayoutTests/fast/canvas/webgl/resources/tex-image-and-sub-image-image-bitmap-utils.js

Index: third_party/WebKit/LayoutTests/fast/canvas/webgl/resources/tex-image-and-sub-image-image-bitmap-utils.js
diff --git a/third_party/WebKit/LayoutTests/fast/canvas/webgl/resources/tex-image-and-sub-image-image-bitmap-utils.js b/third_party/WebKit/LayoutTests/fast/canvas/webgl/resources/tex-image-and-sub-image-image-bitmap-utils.js
index f545c3874a9bd52ff424eaedd113d595f8acf0fd..32c60694df4bdb2569786e690aeef786d33fda84 100644
--- a/third_party/WebKit/LayoutTests/fast/canvas/webgl/resources/tex-image-and-sub-image-image-bitmap-utils.js
+++ b/third_party/WebKit/LayoutTests/fast/canvas/webgl/resources/tex-image-and-sub-image-image-bitmap-utils.js
@@ -24,6 +24,8 @@ function runOneIteration(useTexSubImage2D, bindingTarget, program, bitmap, flipY
     // Set up texture parameters
     gl.texParameteri(bindingTarget, gl.TEXTURE_MIN_FILTER, gl.NEAREST);
     gl.texParameteri(bindingTarget, gl.TEXTURE_MAG_FILTER, gl.NEAREST);
+    gl.texParameteri(bindingTarget, gl.TEXTURE_WRAP_S, gl.CLAMP_TO_EDGE);
+    gl.texParameteri(bindingTarget, gl.TEXTURE_WRAP_T, gl.CLAMP_TO_EDGE);
 
     var targets = [gl.TEXTURE_2D];
     if (bindingTarget == gl.TEXTURE_CUBE_MAP) {
@@ -131,7 +133,7 @@ function runTest(bitmaps, alphaVal, colorSpaceEffective)
     var retVal = {testPassed: true, alpha: alphaVal, colorSpaceEffect: colorSpaceEffective};
     var program = tiu.setupTexturedQuad(gl, internalFormat);
     runTestOnBindingTarget(gl.TEXTURE_2D, program, bitmaps, retVal);
-    program = tiu.setupTexturedQuadWithCubeMap(gl, internalFormat);
-    runTestOnBindingTarget(gl.TEXTURE_CUBE_MAP, program, bitmaps, retVal);
+    // program = tiu.setupTexturedQuadWithCubeMap(gl, internalFormat);
+    // runTestOnBindingTarget(gl.TEXTURE_CUBE_MAP, program, bitmaps, retVal);

[xidachen, 2016/06/15 12:18:47]

kbr@: could you give some suggestions? This js file is used in many layout
tests. Right now this particular one:
texImage-imageBitmap-from-canvas.html
is timed out when running under virtual/gpu/ mode, without commenting out these
two lines.

What surprises me is that the test runs fine by either:
1. commenting out these two lines
2. or commenting out the two lines above.
Basically running either gl.Texture_2D or gl.Texture_CUBE_MAP is fine, but
running both will time out this test.

I tried to debug, and it seems that the test timed out at the:
tiu.setupTexturedQuadWithCubeMap() line. I don't know what could cause timeout
in that line?

     return retVal.testPassed;
 }