third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp - Issue 2026803002: Avoid GPU readback in tex(Sub)Image2D(ImageBitmap)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp

Issue 2026803002: Avoid GPU readback in tex(Sub)Image2D(ImageBitmap) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: staticbitmapimage does not keep provider anymore Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/ImageBitmap.cpp ('K') | « third_party/WebKit/Source/core/frame/ImageBitmap.cpp ('k') | third_party/WebKit/Source/core/svg/graphics/SVGImage.h » ('j') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp

diff --git a/third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp b/third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp

index 7ee78d3969e1940fc1afd99303e4af4bd04c9e6e..d4ec9ec005a59b38288324c991f6be7b45d6ac73 100644

--- a/third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp

+++ b/third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp

@@ -54,7 +54,7 @@ public:

IntSize size() const override { return IntSize(); }

void destroyDecodedData() override { }

void draw(SkCanvas*, const SkPaint&, const FloatRect& dstRect, const FloatRect& srcRect, RespectImageOrientationEnum, ImageClampingMode) override { }

- PassRefPtr<SkImage> imageForCurrentFrame() override { return nullptr; }

+ PassRefPtr<SkImage> imageForCurrentFrame(WebGraphicsContext3DProvider* = nullptr) override { return nullptr; }

};

TEST_F(ImageQualityControllerTest, ImageMaybeAnimated)

@@ -75,7 +75,7 @@ public:

void draw(SkCanvas*, const SkPaint&, const FloatRect& dstRect, const FloatRect& srcRect, RespectImageOrientationEnum, ImageClampingMode) override { }

bool isBitmapImage() const override { return true; }

- PassRefPtr<SkImage> imageForCurrentFrame() override { return nullptr; }

+ PassRefPtr<SkImage> imageForCurrentFrame(WebGraphicsContext3DProvider* = nullptr) override { return nullptr; }

};

TEST_F(ImageQualityControllerTest, LowQualityFilterForContrast)

@@ -96,7 +96,7 @@ public:

void draw(SkCanvas*, const SkPaint&, const FloatRect& dstRect, const FloatRect& srcRect, RespectImageOrientationEnum, ImageClampingMode) override { }

bool isBitmapImage() const override { return true; }

- PassRefPtr<SkImage> imageForCurrentFrame() override { return nullptr; }

+ PassRefPtr<SkImage> imageForCurrentFrame(WebGraphicsContext3DProvider* = nullptr) override { return nullptr; }

};

TEST_F(ImageQualityControllerTest, MediumQualityFilterForUnscaledImage)