Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

Issue 2026803002: Avoid GPU readback in tex(Sub)Image2D(ImageBitmap) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address kbr@'s comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebGL2RenderingContextBase_h 5 #ifndef WebGL2RenderingContextBase_h
6 #define WebGL2RenderingContextBase_h 6 #define WebGL2RenderingContextBase_h
7 7
8 #include "modules/webgl/WebGLExtension.h" 8 #include "modules/webgl/WebGLExtension.h"
9 #include "modules/webgl/WebGLRenderingContextBase.h" 9 #include "modules/webgl/WebGLRenderingContextBase.h"
10 #include <memory> 10 #include <memory>
(...skipping 254 matching lines...) Expand 10 before | Expand all | Expand 10 after
265 265
266 WebGLTexture* validateTexImageBinding(const char*, TexImageFunctionID, GLenu m) override; 266 WebGLTexture* validateTexImageBinding(const char*, TexImageFunctionID, GLenu m) override;
267 // Helper function to check texture 3D target and texture bound to the targe t. 267 // Helper function to check texture 3D target and texture bound to the targe t.
268 // Generate GL errors and return 0 if target is invalid or texture bound is 268 // Generate GL errors and return 0 if target is invalid or texture bound is
269 // null. Otherwise, return the texture bound to the target. 269 // null. Otherwise, return the texture bound to the target.
270 WebGLTexture* validateTexture3DBinding(const char* functionName, GLenum targ et); 270 WebGLTexture* validateTexture3DBinding(const char* functionName, GLenum targ et);
271 271
272 WebGLBuffer* validateBufferDataTarget(const char* functionName, GLenum targe t) override; 272 WebGLBuffer* validateBufferDataTarget(const char* functionName, GLenum targe t) override;
273 bool validateBufferDataUsage(const char* functionName, GLenum usage) overrid e; 273 bool validateBufferDataUsage(const char* functionName, GLenum usage) overrid e;
274 274
275 bool canUseTexImageCanvasByGPU(GLint internalformat, GLenum type) override; 275 bool canUseTexImageByGPU(TexImageFunctionID, GLint internalformat, GLenum ty pe) override;
276 276
277 void removeBoundBuffer(WebGLBuffer*) override; 277 void removeBoundBuffer(WebGLBuffer*) override;
278 278
279 void resetUnpackParameters() override; 279 void resetUnpackParameters() override;
280 void restoreUnpackParameters() override; 280 void restoreUnpackParameters() override;
281 281
282 Member<WebGLFramebuffer> m_readFramebufferBinding; 282 Member<WebGLFramebuffer> m_readFramebufferBinding;
283 Member<WebGLTransformFeedback> m_transformFeedbackBinding; 283 Member<WebGLTransformFeedback> m_transformFeedbackBinding;
284 284
285 std::set<GLenum> m_supportedInternalFormatsStorage; 285 std::set<GLenum> m_supportedInternalFormatsStorage;
(...skipping 28 matching lines...) Expand all
314 ScopedPersistent<v8::Array> m_queryWrappers; 314 ScopedPersistent<v8::Array> m_queryWrappers;
315 }; 315 };
316 316
317 DEFINE_TYPE_CASTS(WebGL2RenderingContextBase, CanvasRenderingContext, context, 317 DEFINE_TYPE_CASTS(WebGL2RenderingContextBase, CanvasRenderingContext, context,
318 context->is3d() && WebGLRenderingContextBase::getWebGLVersion(context) >= 2, 318 context->is3d() && WebGLRenderingContextBase::getWebGLVersion(context) >= 2,
319 context.is3d() && WebGLRenderingContextBase::getWebGLVersion(&context) >= 2) ; 319 context.is3d() && WebGLRenderingContextBase::getWebGLVersion(&context) >= 2) ;
320 320
321 } // namespace blink 321 } // namespace blink
322 322
323 #endif 323 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698