third_party/WebKit/Source/core/html/canvas/CanvasImageSource.h - Issue 2026803002: Avoid GPU readback in tex(Sub)Image2D(ImageBitmap)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/html/canvas/CanvasImageSource.h

Issue 2026803002: Avoid GPU readback in tex(Sub)Image2D(ImageBitmap) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: should work Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLCanvasElement.h ('k') | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2006, 2007, 2008 Apple Computer, Inc. All rights reserved.	2 * Copyright (C) 2006, 2007, 2008 Apple Computer, Inc. All rights reserved.

3 * Copyright (C) 2007 Alp Toker <alp@atoker.com>	3 * Copyright (C) 2007 Alp Toker <alp@atoker.com>

4 *	4 *

5 * Redistribution and use in source and binary forms, with or without	5 * Redistribution and use in source and binary forms, with or without

6 * modification, are permitted provided that the following conditions	6 * modification, are permitted provided that the following conditions

7 * are met:	7 * are met:

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 50 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
61	61

62 // Adjusts the source and destination rectangles for cases where the actual	62 // Adjusts the source and destination rectangles for cases where the actual

63 // source image is a subregion of the image returned by getSourceImageForCan vas.	63 // source image is a subregion of the image returned by getSourceImageForCan vas.

64 virtual void adjustDrawRects(FloatRect* srcRect, FloatRect* dstRect) const { }	64 virtual void adjustDrawRects(FloatRect* srcRect, FloatRect* dstRect) const { }

65	65

66 virtual FloatSize elementSize(const FloatSize& defaultObjectSize) const = 0;	66 virtual FloatSize elementSize(const FloatSize& defaultObjectSize) const = 0;

67 virtual FloatSize defaultDestinationSize(const FloatSize& defaultObjectSize) const { return elementSize(defaultObjectSize); }	67 virtual FloatSize defaultDestinationSize(const FloatSize& defaultObjectSize) const { return elementSize(defaultObjectSize); }

68 virtual const KURL& sourceURL() const { return blankURL(); }	68 virtual const KURL& sourceURL() const { return blankURL(); }

69 virtual bool isOpaque() const { return false; }	69 virtual bool isOpaque() const { return false; }

70	70

	71 virtual int sourceWidth() { return 0; }
	Justin Novosad 2016/06/23 14:48:43 This should be pure virtual IMHO. The default beha This should be pure virtual IMHO. The default behavior of returning 0 is not the correct result for any of the subclasses
	72 virtual int sourceHeight() { return 0; }

	73

71 protected:	74 protected:

72 virtual ~CanvasImageSource() { }	75 virtual ~CanvasImageSource() { }

73 };	76 };

74	77

75 } // namespace blink	78 } // namespace blink

76	79

77 #endif	80 #endif

OLD	NEW