Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1274)

Issue 2026793002: TableView: use a stable_sort instead of a sort, since the comparisons may not be totally ordered. (Closed)

Created:
4 years, 6 months ago by ncarter (slow)
Modified:
4 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

TableView: use a stable_sort instead of a sort, since the comparisons may not be totally ordered. BUG=606985 Committed: https://crrev.com/ed4c02aa36bc1c0cda34315d0f51f7b8aa7e794f Cr-Commit-Position: refs/heads/master@{#396937}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M ui/views/controls/table/table_view.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ncarter (slow)
Hi sky: please review
4 years, 6 months ago (2016-05-31 18:09:35 UTC) #2
sky
LGTM
4 years, 6 months ago (2016-05-31 20:52:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026793002/1
4 years, 6 months ago (2016-05-31 21:29:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 21:36:56 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 21:38:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed4c02aa36bc1c0cda34315d0f51f7b8aa7e794f
Cr-Commit-Position: refs/heads/master@{#396937}

Powered by Google App Engine
This is Rietveld 408576698