Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 2026773002: Fix for flaky MHTMLGenerationTest.ViewedMHTMLContainsNoStoreContentIfNoCacheControlPolicy test. (Closed)

Created:
4 years, 6 months ago by paulmeyer
Modified:
4 years, 6 months ago
Reviewers:
ncarter (slow), dewittj
CC:
chromium-reviews, asanka, darin-cc_chromium.org, jam, dewittj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for flaky MHTMLGenerationTest.ViewedMHTMLContainsNoStoreContentIfNoCacheControlPolicy test. The problem is here: https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/download/mhtml_generation_browsertest.cc&l=61 The number of matches is checked at the first reply to the find request, without checking that the find operation actually finished. The number of matches should be checked only when |final_update| is true. BUG=616110 Committed: https://crrev.com/d7c18f6c0bc2c601ee718e61fac29280e7059042 Cr-Commit-Position: refs/heads/master@{#396869}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M content/browser/download/mhtml_generation_browsertest.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026773002/1
4 years, 6 months ago (2016-05-31 17:11:37 UTC) #2
paulmeyer
4 years, 6 months ago (2016-05-31 17:12:57 UTC) #4
dewittj
not the OWNER, but lgtm. Thanks for the fix!
4 years, 6 months ago (2016-05-31 17:15:54 UTC) #6
dewittj
also, these tests were disabled on Android, could you re-enable them?
4 years, 6 months ago (2016-05-31 17:17:05 UTC) #7
ncarter (slow)
lgtm
4 years, 6 months ago (2016-05-31 17:37:57 UTC) #8
paulmeyer
On 2016/05/31 17:17:05, dewittj wrote: > also, these tests were disabled on Android, could you ...
4 years, 6 months ago (2016-05-31 18:08:45 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-31 18:15:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026773002/1
4 years, 6 months ago (2016-05-31 18:18:21 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 18:23:25 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 18:25:08 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d7c18f6c0bc2c601ee718e61fac29280e7059042
Cr-Commit-Position: refs/heads/master@{#396869}

Powered by Google App Engine
This is Rietveld 408576698