Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2026703002: Revert of [gn] Add cctest (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [gn] Add cctest (patchset #4 id:60001 of https://codereview.chromium.org/2007143003/ ) Reason for revert: Still http://crbug.com/615890 Original issue's description: > [gn] Add cctest > > BUG=chromium:474921 > > Committed: https://crrev.com/52a6fced896e3f64ac56eb57bcdea78393642e0c > Cr-Commit-Position: refs/heads/master@{#36517} > > Committed: https://crrev.com/65678bc67fc48dfe4dcab7fdd2c4b7e1d6e918f4 > Cr-Commit-Position: refs/heads/master@{#36586} > > TBR=jochen@chromium.org > > Committed: https://crrev.com/eea9fbe1858df23dd832ed8ddd284f98120d9e21 > Cr-Commit-Position: refs/heads/master@{#36607} TBR=jochen@chromium.org,vogelheim@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:474921 Committed: https://crrev.com/dae83bf0f7167b2b8be98195a73435159bd5491a Cr-Commit-Position: refs/heads/master@{#36615}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -352 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D test/cctest/BUILD.gn View 1 chunk +0 lines, -350 lines 0 comments Download
M test/cctest/test-platform.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [gn] Add cctest
4 years, 6 months ago (2016-05-31 14:29:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026703002/1
4 years, 6 months ago (2016-05-31 14:29:36 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 14:29:48 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 14:30:21 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dae83bf0f7167b2b8be98195a73435159bd5491a
Cr-Commit-Position: refs/heads/master@{#36615}

Powered by Google App Engine
This is Rietveld 408576698