Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2026663005: cc: Change tile manager to have a raw ptr for the task runner. (Closed)

Created:
4 years, 6 months ago by vmpstr
Modified:
4 years, 6 months ago
Reviewers:
reveman, ericrk
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Change tile manager to have a raw ptr for the task runner. This patch changes |task_runner_| member in tile manager to be a raw pointer instead of a scoped_refptr. All the codepaths seem to guarantee that the task runner outlives tile manager, so there is no need to create a scoped_refptr a raw pointer at tile manager creation time. R=ericrk, reveman CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/a23ee26fe80a2df53f6e4760a2abbf694a6b4f7f Cr-Commit-Position: refs/heads/master@{#397241}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -13 lines) Patch
M cc/test/fake_tile_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/tiles/tile_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/tiles/tile_manager.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
vmpstr
Please take a look. I think every use of task_runner_ would ensure that it either ...
4 years, 6 months ago (2016-05-31 23:25:43 UTC) #2
reveman
lgtm
4 years, 6 months ago (2016-06-01 00:11:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026663005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026663005/1
4 years, 6 months ago (2016-06-01 19:47:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 21:09:52 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 21:12:58 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a23ee26fe80a2df53f6e4760a2abbf694a6b4f7f
Cr-Commit-Position: refs/heads/master@{#397241}

Powered by Google App Engine
This is Rietveld 408576698