Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6223)

Unified Diff: chrome/browser/permissions/permission_manager.cc

Issue 2026663002: Record Rappor metrics even for constant permissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/permissions/permission_uma_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_manager.cc
diff --git a/chrome/browser/permissions/permission_manager.cc b/chrome/browser/permissions/permission_manager.cc
index bad0233269519ee55361667b5b8253d1b4503e25..8578187e384cf12aa89fbb355d90c8b8086d19f2 100644
--- a/chrome/browser/permissions/permission_manager.cc
+++ b/chrome/browser/permissions/permission_manager.cc
@@ -17,6 +17,7 @@
#include "chrome/browser/permissions/permission_context_base.h"
#include "chrome/browser/permissions/permission_manager_factory.h"
#include "chrome/browser/permissions/permission_request_id.h"
+#include "chrome/browser/permissions/permission_uma_util.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/push_messaging/push_messaging_permission_context.h"
#include "chrome/browser/storage/durable_storage_permission_context.h"
@@ -293,6 +294,11 @@ int PermissionManager::RequestPermissions(
if (IsConstantPermission(permission) ||
!GetPermissionContext(permission)) {
+ if (IsConstantPermission(permission)) {
mlamouri (slow - plz ping) 2016/05/31 15:40:04 I think you could even remove the check. |GetPermi
Takashi Toyoshima 2016/06/01 05:11:52 Done.
+ // Track permission request usages even for constant permissions.
+ PermissionUmaUtil::PermissionRequested(permission, requesting_origin,
+ embedding_origin, profile_);
+ }
OnPermissionsRequestResponseStatus(request_id, i,
GetPermissionStatus(permission, requesting_origin, embedding_origin));
continue;
« no previous file with comments | « no previous file | chrome/browser/permissions/permission_uma_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698