Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: runtime/vm/scavenger.cc

Issue 2026643004: Don't overload FreeListElement for become. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/raw_object.cc ('k') | runtime/vm/service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/scavenger.cc
diff --git a/runtime/vm/scavenger.cc b/runtime/vm/scavenger.cc
index 03f0912a395582ebf2fa1d531941916b0d002ded..306a78a4978ac104cb62f3d870690a344235ff12 100644
--- a/runtime/vm/scavenger.cc
+++ b/runtime/vm/scavenger.cc
@@ -464,11 +464,9 @@ void Scavenger::IterateStoreBuffers(Isolate* isolate,
total_count += count;
while (!pending->IsEmpty()) {
RawObject* raw_object = pending->Pop();
- if (raw_object->IsFreeListElement()) {
- // TODO(rmacnak): Forwarding corpse from become. Probably we should also
- // visit the store buffer blocks during become, and mark any forwardees
- // as remembered if their forwarders are remembered to satisfy the
- // following assert.
+ if (raw_object->IsForwardingCorpse()) {
+ // A source object in a become was a remembered object, but we do
+ // not visit the store buffer during become to remove it.
continue;
}
ASSERT(raw_object->IsRemembered());
« no previous file with comments | « runtime/vm/raw_object.cc ('k') | runtime/vm/service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698