Don't overload FreeListElement for become.

runtime/vm/scavenger.cc

Index: runtime/vm/scavenger.cc
diff --git a/runtime/vm/scavenger.cc b/runtime/vm/scavenger.cc
index 03f0912a395582ebf2fa1d531941916b0d002ded..94376c7bf563a83d66240d345886870cdc782582 100644
--- a/runtime/vm/scavenger.cc
+++ b/runtime/vm/scavenger.cc
@@ -464,11 +464,9 @@ void Scavenger::IterateStoreBuffers(Isolate* isolate,
     total_count += count;
     while (!pending->IsEmpty()) {
       RawObject* raw_object = pending->Pop();
-      if (raw_object->IsFreeListElement()) {
-        // TODO(rmacnak): Forwarding corpse from become. Probably we should also
-        // visit the store buffer blocks during become, and mark any forwardees
-        // as remembered if their forwarders are remembered to satisfy the
-        // following assert.
+      if (raw_object->IsForwardingCorpse()) {
+        // The left-hand side of a become was a remembered object, but we do

[Cutch, 2016/06/02 14:09:53]

Was the TODO stale?

[rmacnak, 2016/06/02 17:57:06]

The use of StorePointer during forwarding satisfies the following assert. The
rest of the todo was a bit confused because "remembered-ness" is not a property
that is forwarded.

+        // not visit the store buffer during become.
         continue;
       }
       ASSERT(raw_object->IsRemembered());