Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 2026643003: [json] replace remaining json.js code with C++ builtins. (Closed)

Created:
4 years, 6 months ago by Yang
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[json] replace remaining json.js code with C++ builtins. R=bmeurer@chromium.org Committed: https://crrev.com/60afed46a0b2ed5b1581aeda6450822a7898a8a4 Cr-Commit-Position: refs/heads/master@{#36610}

Patch Set 1 #

Patch Set 2 : revert unrelated changes in BUILD.gn #

Patch Set 3 : fix error message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -101 lines) Patch
M BUILD.gn View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/bootstrapper.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M src/builtins.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/builtins.cc View 1 2 3 chunks +42 lines, -0 lines 0 comments Download
D src/js/json.js View 1 chunk +0 lines, -53 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +0 lines, -3 lines 0 comments Download
D src/runtime/runtime-json.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M src/v8.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M test/mjsunit/debug-script.js View 1 chunk +0 lines, -5 lines 0 comments Download
M test/webkit/run-json-stringify-expected.txt View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Yang
4 years, 6 months ago (2016-05-31 07:17:20 UTC) #1
Benedikt Meurer
Awesome cleanup, thanks! LGTM.
4 years, 6 months ago (2016-05-31 07:22:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026643003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026643003/20001
4 years, 6 months ago (2016-05-31 07:23:16 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/2382) v8_linux64_avx2_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 6 months ago (2016-05-31 07:40:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026643003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026643003/40001
4 years, 6 months ago (2016-05-31 09:05:48 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-05-31 09:32:33 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 09:35:05 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/60afed46a0b2ed5b1581aeda6450822a7898a8a4
Cr-Commit-Position: refs/heads/master@{#36610}

Powered by Google App Engine
This is Rietveld 408576698