Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1554)

Unified Diff: src/heap/objects-visiting-inl.h

Issue 2026633003: Reland "[heap] Fine-grained JSArrayBuffer tracking" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Tests should not assert for promotion decisions but only for tracking Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/objects-visiting.h ('k') | src/heap/scavenger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/objects-visiting-inl.h
diff --git a/src/heap/objects-visiting-inl.h b/src/heap/objects-visiting-inl.h
index c504988436f79f562eb73530db3ff4b30da489da..eeb99fc33b01e940a1462bdb2bf7a450105ef10c 100644
--- a/src/heap/objects-visiting-inl.h
+++ b/src/heap/objects-visiting-inl.h
@@ -77,7 +77,10 @@ void StaticNewSpaceVisitor<StaticVisitor>::Initialize() {
&FlexibleBodyVisitor<StaticVisitor, JSFunction::BodyDescriptorWeakCode,
int>::Visit);
- table_.Register(kVisitJSArrayBuffer, &VisitJSArrayBuffer);
+ table_.Register(
+ kVisitJSArrayBuffer,
+ &FlexibleBodyVisitor<StaticVisitor, JSArrayBuffer::BodyDescriptor,
+ int>::Visit);
table_.Register(kVisitFreeSpace, &VisitFreeSpace);
@@ -99,21 +102,6 @@ void StaticNewSpaceVisitor<StaticVisitor>::Initialize() {
kVisitStructGeneric>();
}
-
-template <typename StaticVisitor>
-int StaticNewSpaceVisitor<StaticVisitor>::VisitJSArrayBuffer(
- Map* map, HeapObject* object) {
- typedef FlexibleBodyVisitor<StaticVisitor, JSArrayBuffer::BodyDescriptor, int>
- JSArrayBufferBodyVisitor;
-
- if (!JSArrayBuffer::cast(object)->is_external()) {
- Heap* heap = map->GetHeap();
- heap->array_buffer_tracker()->MarkLive(JSArrayBuffer::cast(object));
- }
- return JSArrayBufferBodyVisitor::Visit(map, object);
-}
-
-
template <typename StaticVisitor>
int StaticNewSpaceVisitor<StaticVisitor>::VisitBytecodeArray(
Map* map, HeapObject* object) {
@@ -185,7 +173,10 @@ void StaticMarkingVisitor<StaticVisitor>::Initialize() {
table_.Register(kVisitJSFunction, &VisitJSFunction);
- table_.Register(kVisitJSArrayBuffer, &VisitJSArrayBuffer);
+ table_.Register(
+ kVisitJSArrayBuffer,
+ &FlexibleBodyVisitor<StaticVisitor, JSArrayBuffer::BodyDescriptor,
+ void>::Visit);
// Registration for kVisitJSRegExp is done by StaticVisitor.
@@ -520,24 +511,6 @@ void StaticMarkingVisitor<StaticVisitor>::VisitJSRegExp(Map* map,
JSObjectVisitor::Visit(map, object);
}
-
-template <typename StaticVisitor>
-void StaticMarkingVisitor<StaticVisitor>::VisitJSArrayBuffer(
- Map* map, HeapObject* object) {
- Heap* heap = map->GetHeap();
-
- typedef FlexibleBodyVisitor<StaticVisitor, JSArrayBuffer::BodyDescriptor,
- void> JSArrayBufferBodyVisitor;
-
- JSArrayBufferBodyVisitor::Visit(map, object);
-
- if (!JSArrayBuffer::cast(object)->is_external() &&
- !heap->InNewSpace(object)) {
- heap->array_buffer_tracker()->MarkLive(JSArrayBuffer::cast(object));
- }
-}
-
-
template <typename StaticVisitor>
void StaticMarkingVisitor<StaticVisitor>::VisitBytecodeArray(
Map* map, HeapObject* object) {
« no previous file with comments | « src/heap/objects-visiting.h ('k') | src/heap/scavenger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698