Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: ui/views/mus/views_mus_test_suite.cc

Issue 2026623002: views/mus: Have explicit ownership of views::WindowManagerConnection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tot-merge Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/mus/views_mus_test_suite.cc
diff --git a/ui/views/mus/views_mus_test_suite.cc b/ui/views/mus/views_mus_test_suite.cc
index ea8e031c8e95391819f71564661c9a0d699c296b..8ed0500997c1b6445778f090d73c9767ff24e2e8 100644
--- a/ui/views/mus/views_mus_test_suite.cc
+++ b/ui/views/mus/views_mus_test_suite.cc
@@ -46,11 +46,13 @@ class PlatformTestHelperMus : public PlatformTestHelper {
const shell::Identity& identity) {
// It is necessary to recreate the WindowManagerConnection for each test,
// since a new MessageLoop is created for each test.
- WindowManagerConnection::Create(connector, identity);
+ connection_ = WindowManagerConnection::Create(connector, identity);
}
- ~PlatformTestHelperMus() override { WindowManagerConnection::Reset(); }
+ ~PlatformTestHelperMus() override {}
private:
+ std::unique_ptr<WindowManagerConnection> connection_;
+
DISALLOW_COPY_AND_ASSIGN(PlatformTestHelperMus);
};
@@ -84,8 +86,6 @@ class ShellConnection {
}
~ShellConnection() {
- if (views::WindowManagerConnection::Exists())
- views::WindowManagerConnection::Reset();
base::WaitableEvent wait(false, false);
thread_.task_runner()->PostTask(
FROM_HERE, base::Bind(&ShellConnection::TearDownConnections,

Powered by Google App Engine
This is Rietveld 408576698