mash/catalog_viewer/catalog_viewer.cc - Issue 2026623002: views/mus: Have explicit ownership of views::WindowManagerConnection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mash/catalog_viewer/catalog_viewer.cc

Issue 2026623002: views/mus: Have explicit ownership of views::WindowManagerConnection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mash/catalog_viewer/catalog_viewer.h ('K') | « mash/catalog_viewer/catalog_viewer.h ('k') | mash/example/views_examples/views_examples_application_delegate.h » ('j') | mash/example/views_examples/views_examples_application_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mash/catalog_viewer/catalog_viewer.cc

diff --git a/mash/catalog_viewer/catalog_viewer.cc b/mash/catalog_viewer/catalog_viewer.cc

index 0ecb86e1f000ad8060cbfcd7689bb37e0708bf6c..d693bacbc24a383251056543f60898b10591f005 100644

--- a/mash/catalog_viewer/catalog_viewer.cc

+++ b/mash/catalog_viewer/catalog_viewer.cc

@@ -182,7 +182,7 @@ void CatalogViewer::Initialize(shell::Connector* connector,

tracing_.Initialize(connector, identity.name());

aura_init_.reset(new views::AuraInit(connector, "views_mus_resources.pak"));

- views::WindowManagerConnection::Create(connector, identity);

+ views_mus_ = views::WindowManagerConnection::Create(connector, identity);

}

bool CatalogViewer::AcceptConnection(shell::Connection* connection) {