Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 20266003: drive: Add ResourceMetadataStorage::Iterator::GetCacheEntry() (Closed)

Created:
7 years, 5 months ago by hashimoto
Modified:
7 years, 5 months ago
Reviewers:
kinaba
CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

drive: Add ResourceMetadataStorage::Iterator::GetCacheEntry() Seeking a nearby entry can be about 20x faster than looking up the whole DB. BUG=262323 TEST=unit_tests R=kinaba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213750

Patch Set 1 #

Patch Set 2 : Remove unneeded cache argument #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -38 lines) Patch
M chrome/browser/chromeos/drive/file_system.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata_storage.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata_storage.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata_storage_unittest.cc View 1 chunk +23 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/drive/search_metadata.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/search_metadata.cc View 1 9 chunks +9 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/drive/search_metadata_unittest.cc View 1 13 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hashimoto
Please review. Below is shown how the 'OFFLINE' case performance gets improved with this change. ...
7 years, 5 months ago (2013-07-25 09:26:58 UTC) #1
kinaba
Great! lgtm
7 years, 5 months ago (2013-07-26 01:30:32 UTC) #2
hashimoto
7 years, 5 months ago (2013-07-26 03:25:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r213750 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698