Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 20266002: Changed Test cases with new keyword NeedsRebaseline for revision=154604 (Closed)

Created:
7 years, 5 months ago by a.suchit
Modified:
7 years, 5 months ago
Reviewers:
suchit.agrawal, eseidel
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Changed Test cases with new keyword NeedsRebaseline for revision=154604 > Height of fixed height cell is not proper when cell's row is under row spanning cell. > > If cell have fixed height then it's height should not changed till there is > other rows present to take extra rowspan cell height. > > Extra rowspan cell height, First, distributes to percent height spanning rows > which is depend on table height. If extra rowspan cell height remains after > distributing to percent height rows then remaining extra rowspan cell height > distributes in auto spanning rows if auto spanning rows are present otherwise > it distributes to remaining spanning rows. > > R=jchaffraix@chromium.org > BUG=254914 > > Review URL : https://codereview.chromium.org/18050007 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154906

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +11 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
suchit.agrawal
7 years, 5 months ago (2013-07-25 06:57:05 UTC) #1
eseidel
lgtm
7 years, 5 months ago (2013-07-25 07:15:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a.suchit@samsung.com/20266002/1
7 years, 5 months ago (2013-07-25 07:16:47 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-25 08:26:51 UTC) #4
Message was sent while issue was closed.
Change committed as 154906

Powered by Google App Engine
This is Rietveld 408576698