Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 2026553002: Fix failure in RunWasmInterpreted_LoadMemI32_const_oob_misaligned on architecures that don't suppor… (Closed)

Created:
4 years, 6 months ago by ivica.bogosavljevic
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix failure in RunWasmInterpreted_LoadMemI32_const_oob_misaligned on architecures that don't support unaligned access BUG=cctest/test-run-wasm/RunWasmInterpreted_LoadMemI32_const_oob_misaligned Committed: https://crrev.com/2cd66cabd63418806336d4bbcebda1a55d2a641d Cr-Commit-Position: refs/heads/master@{#36590}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M src/wasm/wasm-interpreter.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
ivica.bogosavljevic
PTAL
4 years, 6 months ago (2016-05-30 13:21:11 UTC) #3
titzer
lgtm
4 years, 6 months ago (2016-05-30 13:27:24 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026553002/1
4 years, 6 months ago (2016-05-30 13:37:39 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-30 14:06:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026553002/1
4 years, 6 months ago (2016-05-30 14:11:14 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-30 14:13:14 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 14:16:01 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2cd66cabd63418806336d4bbcebda1a55d2a641d
Cr-Commit-Position: refs/heads/master@{#36590}

Powered by Google App Engine
This is Rietveld 408576698