Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2026503002: Add js-perf-test benchmark for generators. (Closed)

Created:
4 years, 6 months ago by neis
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add js-perf-test benchmark for generators. BUG=v8:4907 Committed: https://crrev.com/20e43a3a933619af1f837ca7cb65fd8481ad09e6 Cr-Commit-Position: refs/heads/master@{#36583}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -2 lines) Patch
A test/js-perf-test/Generators/generators.js View 1 chunk +131 lines, -0 lines 0 comments Download
A + test/js-perf-test/Generators/run.js View 1 chunk +5 lines, -2 lines 0 comments Download
M test/js-perf-test/JSTests.json View 1 chunk +34 lines, -0 lines 1 comment Download

Messages

Total messages: 13 (7 generated)
neis
ptal
4 years, 6 months ago (2016-05-30 11:05:07 UTC) #3
Jarin
lgtm. Thanks!
4 years, 6 months ago (2016-05-30 11:10:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026503002/1
4 years, 6 months ago (2016-05-30 11:11:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-30 11:35:47 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/20e43a3a933619af1f837ca7cb65fd8481ad09e6 Cr-Commit-Position: refs/heads/master@{#36583}
4 years, 6 months ago (2016-05-30 11:36:35 UTC) #11
Michael Achenbach
4 years, 6 months ago (2016-06-02 18:59:51 UTC) #13
Message was sent while issue was closed.
https://codereview.chromium.org/2026503002/diff/1/test/js-perf-test/JSTests.json
File test/js-perf-test/JSTests.json (right):

https://codereview.chromium.org/2026503002/diff/1/test/js-perf-test/JSTests.j...
test/js-perf-test/JSTests.json:17: "results_regexp":
"^%s\\-Generators\\(Score\\): (.+)$"
This is currently failing. A %s makes only sense if you have multiple nested
tests. If not just put the real name there, so that it matches the output, e.g.,
here:
Generators\\-Generators\\(Score\\): (.+)

Powered by Google App Engine
This is Rietveld 408576698