Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2026493002: [GN] Convert generate_localizable_strings.gni to use compiled_action.gni. (Closed)

Created:
4 years, 6 months ago by sdefresne
Modified:
4 years, 6 months ago
Reviewers:
justincohen
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GN] Convert generate_localizable_strings.gni to use compiled_action.gni. BUG=613589 Committed: https://crrev.com/96e1a0b46a0e3cb026d4f63d3ab8265c5d42c92d Cr-Commit-Position: refs/heads/master@{#396756}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -43 lines) Patch
M ios/chrome/tools/strings/generate_localizable_strings.gni View 3 chunks +17 lines, -18 lines 0 comments Download
D ios/chrome/tools/strings/generate_localizable_strings.py View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sdefresne
Please take a look.
4 years, 6 months ago (2016-05-30 09:59:56 UTC) #2
justincohen
lgtm
4 years, 6 months ago (2016-05-30 22:21:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026493002/1
4 years, 6 months ago (2016-05-30 22:22:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-30 22:26:00 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 22:27:30 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/96e1a0b46a0e3cb026d4f63d3ab8265c5d42c92d
Cr-Commit-Position: refs/heads/master@{#396756}

Powered by Google App Engine
This is Rietveld 408576698