Remove legacy constructor from ChromeGoogleApiClientImpl.

Remove legacy constructor from ChromeGoogleApiClientImpl.

BUG=623927
Committed: https://crrev.com/4f22924f1992244a23fb5edd327cafaba3440195
Cr-Commit-Position: refs/heads/master@{#403270}

[Bernhard Bauer, 2016-06-30 09:22:28]

Description was changed from

==========
Remove legacy constructor from ChromeGoogleApiClientImpl.
==========

to

==========
Remove legacy constructor from ChromeGoogleApiClientImpl.

BUG=623927
==========

[Bernhard Bauer, 2016-06-30 15:42:32]

bauerb@chromium.org changed reviewers:
+ dgn@chromium.org

[Bernhard Bauer, 2016-06-30 15:42:32]

Please review. Thanks!

[dgn, 2016-06-30 17:32:49]

lgtm

[Bernhard Bauer, 2016-06-30 20:22:18]

The CQ bit was checked by bauerb@chromium.org

[commit-bot: I haz the power, 2016-06-30 20:23:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 20:29:07]

Description was changed from

==========
Remove legacy constructor from ChromeGoogleApiClientImpl.

BUG=623927
==========

to

==========
Remove legacy constructor from ChromeGoogleApiClientImpl.

BUG=623927
==========

[commit-bot: I haz the power, 2016-06-30 20:29:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-30 20:29:27]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-30 20:31:21]

Description was changed from

==========
Remove legacy constructor from ChromeGoogleApiClientImpl.

BUG=623927
==========

to

==========
Remove legacy constructor from ChromeGoogleApiClientImpl.

BUG=623927

Committed: https://crrev.com/4f22924f1992244a23fb5edd327cafaba3440195
Cr-Commit-Position: refs/heads/master@{#403270}
==========

[commit-bot: I haz the power, 2016-06-30 20:31:22]

Patchset 2 (id:??) landed as
https://crrev.com/4f22924f1992244a23fb5edd327cafaba3440195
Cr-Commit-Position: refs/heads/master@{#403270}

[Dmitry Skiba, 2016-06-30 21:48:55]

On 2016/06/30 20:31:22, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/4f22924f1992244a23fb5edd327cafaba3440195
> Cr-Commit-Position: refs/heads/master@{#403270}

BTW, this change broke Clank-ToT builder:
https://uberchromegw.corp.google.com/i/internal.client.clank_tot/builders/cla...

[chromium-reviews, 2016-06-30 21:50:43]

Yes, fix is in the works:
https://chrome-internal-review.googlesource.com/268105 Sorry!

On Thu, Jun 30, 2016, 22:48 <dskiba@google.com> wrote:

> On 2016/06/30 20:31:22, commit-bot: I haz the power wrote:
> > Patchset 2 (id:??) landed as
> > https://crrev.com/4f22924f1992244a23fb5edd327cafaba3440195
> > Cr-Commit-Position: refs/heads/master@{#403270}
>
> BTW, this change broke Clank-ToT builder:
>
>
https://uberchromegw.corp.google.com/i/internal.client.clank_tot/builders/cla...
>
> https://codereview.chromium.org/2026483003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.