Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__clang_.json

Issue 2026473002: WebRTC: Use goma from cipd (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__clang_.json
diff --git a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__clang_.json b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__clang_.json
index 8a90c4f09dac5ad872b9bbbe16664f41515ed303..8d7f406e7b586b9cb9a4670bb0e795e2fe9ee5bf 100644
--- a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__clang_.json
+++ b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__clang_.json
@@ -91,6 +91,60 @@
"name": "gclient runhooks"
},
{
+ "cmd": [],
+ "name": "ensure_goma"
+ },
+ {
+ "cmd": [
+ "python",
+ "-u",
+ "RECIPE_MODULE[build::cipd]\\resources\\bootstrap.py",
+ "--platform",
+ "windows-386",
+ "--dest-directory",
+ "[SLAVE_BUILD]\\cipd",
+ "--json-output",
+ "/path/to/tmp/json"
+ ],
+ "name": "ensure_goma.install cipd",
+ "~followup_annotations": [
+ "@@@STEP_NEST_LEVEL@1@@@",
+ "@@@STEP_TEXT@cipd instance_id: 40-chars-fake-of-the-package-instance_id@@@",
+ "@@@STEP_LOG_LINE@json.output@{@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"executable\": \"[SLAVE_BUILD]\\\\cipd\\\\cipd\", @@@",
+ "@@@STEP_LOG_LINE@json.output@ \"instance_id\": \"40-chars-fake-of-the-package-instance_id\"@@@",
+ "@@@STEP_LOG_LINE@json.output@}@@@",
+ "@@@STEP_LOG_END@json.output@@@"
+ ]
+ },
+ {
+ "cmd": [
+ "[SLAVE_BUILD]\\cipd\\cipd",
+ "ensure",
+ "--root",
+ "[CACHE]\\cipd\\goma",
+ "--list",
+ "infra_internal/goma/client/windows-amd64 release",
+ "--json-output",
+ "/path/to/tmp/json",
+ "--service-account-json",
+ "C:\\creds\\service_accounts\\service-account-goma-client.json"
+ ],
+ "name": "ensure_goma.ensure_installed",
+ "~followup_annotations": [
+ "@@@STEP_NEST_LEVEL@1@@@",
+ "@@@STEP_LOG_LINE@json.output@{@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"result\": [@@@",
+ "@@@STEP_LOG_LINE@json.output@ {@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"instance_id\": \"resolved-instance_id-of-release---------\", @@@",
+ "@@@STEP_LOG_LINE@json.output@ \"package\": \"infra_internal/goma/client/windows-amd64\"@@@",
+ "@@@STEP_LOG_LINE@json.output@ }@@@",
+ "@@@STEP_LOG_LINE@json.output@ ]@@@",
+ "@@@STEP_LOG_LINE@json.output@}@@@",
+ "@@@STEP_LOG_END@json.output@@@"
+ ]
+ },
+ {
"allow_subannotations": true,
"cmd": [
"python",
@@ -139,7 +193,7 @@
"--goma-service-account-json-file",
"C:\\creds\\service_accounts\\service-account-goma-client.json",
"--goma-dir",
- "[BUILD]\\goma",
+ "[CACHE]\\cipd\\goma",
"--",
"All"
],

Powered by Google App Engine
This is Rietveld 408576698