Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2026463002: Reland "[heap] Fine-grained JSArrayBuffer tracking" (Closed)

Created:
4 years, 6 months ago by Michael Lippautz
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "[heap] Fine-grained JSArrayBuffer tracking" Track based on JSArrayBuffer addresses on pages instead of the attached backing store. Details of tracking: - Scavenge: New space pages are processes in bulk on the main thread - MC: Unswept pages are processed in bulk in parallel. All other pages are processed by the sweeper concurrently. BUG=chromium:614730, chromium:611688 LOG=N CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg,v8_linux_gc_stress_dbg,v8_mac_gc_stress_dbg,v8_linux64_tsan_rel,v8_mac64_asan_rel Committed: https://crrev.com/bc0fb6e83eb7351f52bfd6f780bb6c12bd87c58c Cr-Commit-Position: refs/heads/master@{#36592}

Patch Set 1 : base #

Patch Set 2 : Fix recording on pages where we abort compaction #

Patch Set 3 : make ArrayBufferTracker AllStatic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+617 lines, -183 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/array-buffer-tracker.h View 1 2 2 chunks +90 lines, -40 lines 0 comments Download
M src/heap/array-buffer-tracker.cc View 1 2 1 chunk +136 lines, -90 lines 0 comments Download
A src/heap/array-buffer-tracker-inl.h View 1 1 chunk +87 lines, -0 lines 0 comments Download
M src/heap/heap.h View 1 2 4 chunks +12 lines, -6 lines 0 comments Download
M src/heap/heap.cc View 1 2 6 chunks +3 lines, -11 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 9 chunks +16 lines, -18 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 2 2 chunks +1 line, -6 lines 0 comments Download
M src/heap/scavenger.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/heap/spaces.h View 6 chunks +32 lines, -1 line 0 comments Download
M src/heap/spaces.cc View 3 chunks +10 lines, -1 line 0 comments Download
M src/heap/spaces-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/heap/heap-utils.h View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/heap/heap-utils.cc View 1 chunk +15 lines, -0 lines 0 comments Download
A test/cctest/heap/test-array-buffer-tracker.cc View 1 chunk +206 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
Michael Lippautz
ptal tested using https://codereview.chromium.org/2019343002/
4 years, 6 months ago (2016-05-30 13:17:06 UTC) #3
Hannes Payer (out of office)
lgtm
4 years, 6 months ago (2016-05-30 14:02:20 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026463002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026463002/60001
4 years, 6 months ago (2016-05-30 14:04:58 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-30 14:47:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026463002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026463002/60001
4 years, 6 months ago (2016-05-30 14:49:29 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 6 months ago (2016-05-30 14:51:17 UTC) #15
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/bc0fb6e83eb7351f52bfd6f780bb6c12bd87c58c Cr-Commit-Position: refs/heads/master@{#36592}
4 years, 6 months ago (2016-05-30 14:53:41 UTC) #17
Michael Lippautz
4 years, 6 months ago (2016-05-30 15:48:11 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/2021893002/ by mlippautz@chromium.org.

The reason for reverting is: Investigating new arm simulator failure:
 
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm%20....

Powered by Google App Engine
This is Rietveld 408576698