Issue 2026443002: Version 5.1.281.52 (cherry-pick)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2026443002: Version 5.1.281.52 (cherry-pick) (Closed)

Created:
4 years, 6 months ago by jochen (gone - plz use gerrit)

Modified:
4 years, 6 months ago

Reviewers:
Michael Hablich

CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Paweł Hajdan Jr.

Base URL:
https://chromium.googlesource.com/v8/v8.git@5.1

Target Ref:
refs/pending/branch-heads/5.1

Project:
v8

Visibility:
Public.

Version 5.1.281.52 (cherry-pick) Merged b3d793e48ab513b964d3e21be81f6b6713854ab2 [api] Introduce ReturnValue::Get R=hablich@chromium.org BUG=chromium:601073 Committed: https://chromium.googlesource.com/v8/v8/+/ea5e96ff05035e5d3fc22ce4df0a9b401c0fae5a

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -6 lines)			Patch
M	include/v8.h	View	4 chunks	+21 lines, -5 lines	0 comments	Download
M	include/v8-version.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap/heap.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/cctest/test-api.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

jochen (gone - plz use gerrit)

Committed patchset #1 (id:1) manually as ea5e96ff05035e5d3fc22ce4df0a9b401c0fae5a.

4 years, 6 months ago (2016-05-30 08:17:56 UTC) #3

Michael Hablich

4 years, 6 months ago (2016-05-30 08:57:11 UTC) #4

Message was sent while issue was closed.

On 2016/05/30 08:17:56, jochen (OOO) wrote:
> Committed patchset #1 (id:1) manually as
> ea5e96ff05035e5d3fc22ce4df0a9b401c0fae5a.

lgtm