Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2643)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwSettings.java

Issue 2026423002: Disable video overlay for WebView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moved from glue to AwSettings.java Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/java/src/org/chromium/android_webview/AwSettings.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwSettings.java b/android_webview/java/src/org/chromium/android_webview/AwSettings.java
index 07eaaeab23f10b17271ffc1e749834e397abfd62..ea93c487e7361672424d75e3a878d6b2ebc4c5c2 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwSettings.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwSettings.java
@@ -87,7 +87,7 @@ public class AwSettings {
private boolean mSpatialNavigationEnabled; // Default depends on device features.
private boolean mEnableSupportedHardwareAcceleratedFeatures = false;
private int mMixedContentMode = WebSettings.MIXED_CONTENT_NEVER_ALLOW;
- private boolean mVideoOverlayForEmbeddedVideoEnabled = false;
+
private boolean mForceVideoOverlayForTests = false;
private boolean mOffscreenPreRaster = false;
private int mDisabledMenuItems = MENU_ITEM_NONE;
@@ -1701,19 +1701,7 @@ public class AwSettings {
* @param flag whether to enable the video overlay for the embedded video.
*/
public void setVideoOverlayForEmbeddedVideoEnabled(final boolean enabled) {
- synchronized (mAwSettingsLock) {
- if (mVideoOverlayForEmbeddedVideoEnabled != enabled) {
- mVideoOverlayForEmbeddedVideoEnabled = enabled;
- mEventHandler.runOnUiThreadBlockingAndLocked(new Runnable() {
- @Override
- public void run() {
- if (mNativeAwSettings != 0) {
- nativeUpdateRendererPreferencesLocked(mNativeAwSettings);
- }
- }
- });
- }
- }
+ // No-op, see http://crbug.com/616583
}
/**
@@ -1721,15 +1709,14 @@ public class AwSettings {
* @return true if the WebView enables the video overlay for the embedded video.
*/
public boolean getVideoOverlayForEmbeddedVideoEnabled() {
- synchronized (mAwSettingsLock) {
- return getVideoOverlayForEmbeddedVideoEnabledLocked();
- }
+ // Always false, see http://crbug.com/616583
+ return false;
}
@CalledByNative
private boolean getVideoOverlayForEmbeddedVideoEnabledLocked() {
- assert Thread.holdsLock(mAwSettingsLock);
- return mVideoOverlayForEmbeddedVideoEnabled;
+ // Always false, see http://crbug.com/616583
+ return false;
}
@VisibleForTesting
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698