Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2026423002: Disable video overlay for WebView (Closed)

Created:
4 years, 6 months ago by Tima Vaisburd
Modified:
4 years, 6 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org, DaleCurtis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable video overlay for WebView Video overlay for embedded videos (aka hole punching) is a hidden API in WebSettings that we plan to remove. Disabling it to verify that nobody uses it. BUG=616583 Committed: https://crrev.com/f903f4e383f265cd7a7ee89421bd0f7dc1feccec Cr-Commit-Position: refs/heads/master@{#397458}

Patch Set 1 #

Patch Set 2 : Moved from glue to AwSettings.java #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -19 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwSettings.java View 1 3 chunks +6 lines, -19 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
Tima Vaisburd
PTAL.
4 years, 6 months ago (2016-06-01 20:45:11 UTC) #2
boliu
I would suggest you do this in AwSettings, so that you don't have to worry ...
4 years, 6 months ago (2016-06-01 20:46:09 UTC) #3
Tima Vaisburd
On 2016/06/01 20:46:09, boliu wrote: > I would suggest you do this in AwSettings, so ...
4 years, 6 months ago (2016-06-01 21:12:46 UTC) #4
boliu
lgtm
4 years, 6 months ago (2016-06-01 21:23:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026423002/20001
4 years, 6 months ago (2016-06-01 21:41:30 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/239318)
4 years, 6 months ago (2016-06-02 01:55:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026423002/20001
4 years, 6 months ago (2016-06-02 02:00:35 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/239434)
4 years, 6 months ago (2016-06-02 02:50:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026423002/20001
4 years, 6 months ago (2016-06-02 16:48:15 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-02 17:38:17 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 17:40:31 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f903f4e383f265cd7a7ee89421bd0f7dc1feccec
Cr-Commit-Position: refs/heads/master@{#397458}

Powered by Google App Engine
This is Rietveld 408576698