bluetooth: Repopulate chooser with existing devices

bluetooth: Repopulate chooser with existing devices

Fixes the issue where restarting the scan would not include the
previously discovered devices.

BUG=581544
Committed: https://crrev.com/d129fcb8c726a0705f39895c30fde53f5aa1883b
Cr-Commit-Position: refs/heads/master@{#397440}

[ortuno, 2016-06-01 20:41:13]

ortuno@chromium.org changed reviewers:
+ scheib@chromium.org

[ortuno, 2016-06-01 20:41:14]

scheib: PTAL

[scheib, 2016-06-01 20:57:42]

LGTM

https://codereview.chromium.org/2026413002/diff/1/content/browser/bluetooth/b...
File content/browser/bluetooth/bluetooth_device_chooser_controller.cc (right):

https://codereview.chromium.org/2026413002/diff/1/content/browser/bluetooth/b...
content/browser/bluetooth/bluetooth_device_chooser_controller.cc:433: if
(!chooser_.get()) {
Maybe move this check into StartDeviceDiscovery? 
Do you know how we end up getting into this situation, where there is a RESCAN
and the chooser is closing?

[ortuno, 2016-06-01 22:06:51]

https://codereview.chromium.org/2026413002/diff/1/content/browser/bluetooth/b...
File content/browser/bluetooth/bluetooth_device_chooser_controller.cc (right):

https://codereview.chromium.org/2026413002/diff/1/content/browser/bluetooth/b...
content/browser/bluetooth/bluetooth_device_chooser_controller.cc:433: if
(!chooser_.get()) {
On 2016/06/01 at 20:57:42, scheib wrote:
> Maybe move this check into StartDeviceDiscovery? 
> Do you know how we end up getting into this situation, where there is a RESCAN
and the chooser is closing?

As mentioned offline, we shouldn't get into this state. Changed it to DCHECK.

[ortuno, 2016-06-01 22:07:01]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2016-06-01 22:07:01]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/2026413002/#ps20001
(title: "DCHECK chooser")

[commit-bot: I haz the power, 2016-06-01 22:07:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2026413002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2026413002/20001

[commit-bot: I haz the power, 2016-06-01 23:47:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-01 23:47:40]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ortuno, 2016-06-02 02:03:01]

The CQ bit was checked by ortuno@chromium.org

[commit-bot: I haz the power, 2016-06-02 02:03:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2026413002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2026413002/20001

[commit-bot: I haz the power, 2016-06-02 02:32:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 02:32:54]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ortuno, 2016-06-02 15:22:28]

The CQ bit was checked by ortuno@chromium.org

[commit-bot: I haz the power, 2016-06-02 15:22:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2026413002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2026413002/20001

[commit-bot: I haz the power, 2016-06-02 16:32:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-02 16:34:36]

Description was changed from

==========
bluetooth: Repopulate chooser with existing devices

Fixes the issue where restarting the scan would not include the
previously discovered devices.

BUG=581544
==========

to

==========
bluetooth: Repopulate chooser with existing devices

Fixes the issue where restarting the scan would not include the
previously discovered devices.

BUG=581544

Committed: https://crrev.com/d129fcb8c726a0705f39895c30fde53f5aa1883b
Cr-Commit-Position: refs/heads/master@{#397440}
==========

[commit-bot: I haz the power, 2016-06-02 16:34:38]

Patchset 2 (id:??) landed as
https://crrev.com/d129fcb8c726a0705f39895c30fde53f5aa1883b
Cr-Commit-Position: refs/heads/master@{#397440}