include/core/SkLights.h - Issue 2026393005: Add SampleApp slide with animating lightmapped objects & transparency

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkLights.h

Issue 2026393005: Add SampleApp slide with animating lightmapped objects & transparency (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: ... Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: include/core/SkLights.h

diff --git a/include/core/SkLights.h b/include/core/SkLights.h

index 0a4fb8153e6735ca32fbe5ede5bf6b0546af89b3..c5c54276a39597909ff53a0465a6e97fee5a8743 100644

--- a/include/core/SkLights.h

+++ b/include/core/SkLights.h

@@ -61,7 +61,7 @@ public:

}

- const sk_sp<SkLights> finish() {

egdaniel 2016/06/03 15:52:48 Why remove const here? Is this something where we

robertphillips 2016/06/03 16:35:31 We discussed in person. The consensus is that sk_s

+ sk_sp<SkLights> finish() {

return fLights;

}

« no previous file with comments | « gyp/SampleApp.gyp ('k') | samplecode/SampleLitAtlas.cpp » ('j') | samplecode/SampleLitAtlas.cpp » ('J')