Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2026393004: Add a caps bit to enable/disable the new manual mip-mapper (Closed)

Created:
4 years, 6 months ago by Brian Osman
Modified:
4 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add a caps bit to enable/disable the new manual mip-mapper Turn it off on Adreno3xx devices, because the small-render-target bug on those devices leads to empty mipmaps for the smallest mips. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2026393004 Committed: https://skia.googlesource.com/skia/+/09563cec928da5052972b3dca7f022fca3a72d05

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M src/gpu/gl/GrGLCaps.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 2 chunks +9 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 2 chunks +2 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026393004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026393004/1
4 years, 6 months ago (2016-06-02 15:23:54 UTC) #3
Brian Osman
4 years, 6 months ago (2016-06-02 15:24:58 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-02 15:38:31 UTC) #7
robertphillips
lgtm
4 years, 6 months ago (2016-06-02 15:53:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026393004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026393004/1
4 years, 6 months ago (2016-06-02 15:58:19 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 15:59:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/09563cec928da5052972b3dca7f022fca3a72d05

Powered by Google App Engine
This is Rietveld 408576698