[Autofill] Credit Card Assist Infobar

components/autofill/core/browser/assist_manager.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_ASSIST_MANAGER_H_
+#define COMPONENTS_AUTOFILL_CORE_BROWSER_ASSIST_MANAGER_H_
+
+#include <memory>
+#include <vector>
+
+#include "base/macros.h"
+#include "base/memory/weak_ptr.h"
+#include "components/autofill/core/common/form_data.h"
+
+namespace autofill {
+
+class AutofillManager;
+class CreditCard;
+class FormStructure;
+
+// This class encompasses the triggering rules and the logic for the autofill
+// assisted filling mechanisms.

[Peter Kasting, 2016/08/03 02:25:40]

Is this going to be "assisting" lots more things than credit cards?  I still
have the reservations about these file/class names ("assist" is a really vague
word and the meaning is non-obvious, especially compared with "autofill"); you
fixed some of the infobar-specific ones, but ones like this are still
problematic.

[Mathieu, 2016/08/03 18:34:44]

Yes it will be an assistant for other things in the future like address forms.
It's an assistant to "autofill" that prompts you and would guide you through the
process so I've changed it to autofill_assistant which is less vague.

+class AssistManager {
+ public:
+  explicit AssistManager(AutofillManager* autofill_manager);
+  ~AssistManager();
+
+  // Should be called at every page navigation to clear state.
+  void Reset();
+
+  // Returns whether a credit card assist can be shown. Will go through the
+  // forms in |form_structures| and extract the credit card form.
+  bool CanShowCreditCardAssist(
+      const std::vector<FormStructure*>& form_structures);
+
+  // Will show an assist infobar for the previously extracted form proposing to
+  // autofill it. Should only be called if CanShowCreditCardAssist() returned
+  // true.
+  void ShowAssistForCreditCard(const CreditCard& card);
+
+ private:
+  // Callback to the user accepting the infobar.

[Peter Kasting, 2016/08/03 02:25:40]

Nit: The grammar of this sentence is confusing, especially due to the use of
present tense (is the callback happening while the user is still "accepting",
and if so, why is the function name "did accept"?).  Something like "Called by
the infobar delegate when the user accepts the infobar" would be clearer.

[Mathieu, 2016/08/03 18:34:44]

Done.

+  void OnUserDidAcceptCreditCardFill(const CreditCard& card);
+
+  // Holds the FormData to be filled with a credit card.
+  std::unique_ptr<FormData> credit_card_form_data_;
+
+  // Weak reference to the AutofillManager that created and maintains this
+  // AssistManager.
+  AutofillManager* autofill_manager_;
+
+  base::WeakPtrFactory<AssistManager> weak_ptr_factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(AssistManager);
+};
+
+}  // namespace autofill
+
+#endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_ASSIST_MANAGER_H_