[Autofill] Credit Card Assist Infobar

chrome/browser/autofill/autofill_credit_card_filling_infobar_delegate_mobile_unittest.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/autofill/core/browser/autofill_credit_card_filling_infobar_delegate_mobile.h"
+
+#include <memory>
+
+#include "base/macros.h"
+#include "base/test/histogram_tester.h"
+#include "chrome/test/base/chrome_render_view_host_test_harness.h"
+#include "components/autofill/core/browser/autofill_test_utils.h"
+#include "components/infobars/core/confirm_infobar_delegate.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace autofill {
+
+// In order to use protected methods.

[Peter Kasting, 2016/08/03 02:25:40]

Nit: If you need to declare a subclass just to expose these methods, then just
make those methods public on the base class.

[Mathieu, 2016/08/03 18:34:44]

Done.

+class TestAutofillCreditCardFillingInfoBarDelegateMobile
+    : public AutofillCreditCardFillingInfoBarDelegateMobile {
+ public:
+  TestAutofillCreditCardFillingInfoBarDelegateMobile(
+      const CreditCard& card,
+      const base::Closure& callback)
+      : AutofillCreditCardFillingInfoBarDelegateMobile(card, callback) {}
+
+  using AutofillCreditCardFillingInfoBarDelegateMobile::Accept;
+  using AutofillCreditCardFillingInfoBarDelegateMobile::Cancel;
+  using AutofillCreditCardFillingInfoBarDelegateMobile::InfoBarDismissed;
+};
+
+class AutofillCreditCardFillingInfoBarDelegateMobileTest
+    : public ChromeRenderViewHostTestHarness {
+ public:
+  AutofillCreditCardFillingInfoBarDelegateMobileTest()
+      : infobar_callback_has_run_(false) {}
+  ~AutofillCreditCardFillingInfoBarDelegateMobileTest() override {}
+
+ protected:
+  std::unique_ptr<TestAutofillCreditCardFillingInfoBarDelegateMobile>
+  CreateDelegate();
+
+  void AcceptInfoBarCallback() { infobar_callback_has_run_ = true; }
+
+  bool infobar_callback_has_run_;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(AutofillCreditCardFillingInfoBarDelegateMobileTest);
+};
+
+std::unique_ptr<TestAutofillCreditCardFillingInfoBarDelegateMobile>
+AutofillCreditCardFillingInfoBarDelegateMobileTest::CreateDelegate() {

[Peter Kasting, 2016/08/03 02:25:40]

Nit: If you manage to return to a Create()-based API (see other comments), this
can be eliminated in favor of just calling the real Create() function and having
it return the created delegate.  (A number of existing infobar delegates do
something like this already.)

[Mathieu, 2016/08/03 18:34:44]

Acknowledged.

+  infobar_callback_has_run_ = false;
+  CreditCard credit_card;
+  std::unique_ptr<TestAutofillCreditCardFillingInfoBarDelegateMobile> delegate(
+      new TestAutofillCreditCardFillingInfoBarDelegateMobile(
+          credit_card,
+          base::Bind(&AutofillCreditCardFillingInfoBarDelegateMobileTest::
+                         AcceptInfoBarCallback,
+                     base::Unretained(this))));
+  delegate->set_was_shown(true);
+  return delegate;
+}
+
+// Test that credit card infobar metrics are logged correctly.
+TEST_F(AutofillCreditCardFillingInfoBarDelegateMobileTest, Metrics) {
+  // Accept the infobar.
+  {
+    std::unique_ptr<TestAutofillCreditCardFillingInfoBarDelegateMobile> infobar(
+        CreateDelegate());
+
+    base::HistogramTester histogram_tester;
+    EXPECT_TRUE(infobar->Accept());
+    EXPECT_TRUE(infobar_callback_has_run_);
+    histogram_tester.ExpectBucketCount("Autofill.CreditCardFillingInfoBar",
+                                       AutofillMetrics::INFOBAR_ACCEPTED, 1);
+    infobar.reset();
+    histogram_tester.ExpectBucketCount("Autofill.CreditCardFillingInfoBar",
+                                       AutofillMetrics::INFOBAR_SHOWN, 1);
+  }
+
+  // Cancel the infobar.
+  {
+    std::unique_ptr<ConfirmInfoBarDelegate> infobar(CreateDelegate());
+
+    base::HistogramTester histogram_tester;
+    EXPECT_TRUE(infobar->Cancel());
+    EXPECT_FALSE(infobar_callback_has_run_);
+    histogram_tester.ExpectBucketCount("Autofill.CreditCardFillingInfoBar",
+                                       AutofillMetrics::INFOBAR_DENIED, 1);
+    infobar.reset();
+    histogram_tester.ExpectBucketCount("Autofill.CreditCardFillingInfoBar",
+                                       AutofillMetrics::INFOBAR_SHOWN, 1);
+  }
+
+  // Dismiss the infobar.
+  {
+    std::unique_ptr<ConfirmInfoBarDelegate> infobar(CreateDelegate());
+
+    base::HistogramTester histogram_tester;
+    infobar->InfoBarDismissed();
+    EXPECT_FALSE(infobar_callback_has_run_);
+    histogram_tester.ExpectBucketCount("Autofill.CreditCardFillingInfoBar",
+                                       AutofillMetrics::INFOBAR_DENIED, 1);
+    infobar.reset();
+    histogram_tester.ExpectBucketCount("Autofill.CreditCardFillingInfoBar",
+                                       AutofillMetrics::INFOBAR_SHOWN, 1);
+  }
+
+  // Ignore the infobar.
+  {
+    std::unique_ptr<ConfirmInfoBarDelegate> infobar(CreateDelegate());
+
+    base::HistogramTester histogram_tester;
+    infobar.reset();
+    EXPECT_FALSE(infobar_callback_has_run_);
+    histogram_tester.ExpectBucketCount("Autofill.CreditCardFillingInfoBar",
+                                       AutofillMetrics::INFOBAR_SHOWN, 1);
+    histogram_tester.ExpectBucketCount("Autofill.CreditCardFillingInfoBar",
+                                       AutofillMetrics::INFOBAR_IGNORED, 1);
+  }
+}
+
+}  // namespace autofill