components/autofill/core/browser/autofill_assist_infobar_mobile.h - Issue 2026353002: [Autofill] Credit Card Assist Infobar

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/autofill/core/browser/autofill_assist_infobar_mobile.h

Issue 2026353002: [Autofill] Credit Card Assist Infobar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed more comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/autofill/core/browser/autofill_assist_infobar_delegate_mobile.cc ('K') | « components/autofill/core/browser/autofill_assist_infobar_delegate_mobile.cc ('k') | components/autofill/core/browser/autofill_client.h » ('j') | components/autofill_strings.grdp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_ASSIST_INFOBAR_MOBILE_H_

	6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_ASSIST_INFOBAR_MOBILE_H_

	7

	8 #include <memory>

	9

	10 namespace infobars {

	11 class InfoBar;

	12 }

	13

	14 namespace autofill {

	15

	16 class AutofillAssistInfoBarDelegateMobile;

	17

	18 // Creates an infobar for Autofill assist.

	19 std::unique_ptr<infobars::InfoBar> CreateAssistInfoBar(
	Peter Kasting 2016/07/29 21:26:34 Avoid forward-declaring functions that aren't actu Avoid forward-declaring functions that aren't actually defined in components/. Instead, prefer to put this on e.g. AutofillClient, so people using this component are forced to implement it at compile time and don't get missing symbols at link time. See how the translate component handles translate infobar creation for example. Mathieu 2016/08/01 22:16:57 Done. Show quoted text On 2016/07/29 21:26:34, Peter Kasting wrote: > Avoid forward-declaring functions that aren't actually defined in components/. > Instead, prefer to put this on e.g. AutofillClient, so people using this > component are forced to implement it at compile time and don't get missing > symbols at link time. > > See how the translate component handles translate infobar creation for example. Done.
	20 std::unique_ptr<AutofillAssistInfoBarDelegateMobile> delegate);

	21

	22 } // namespace autofill

	23

	24 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_ASSIST_INFOBAR_MOBILE_H_

OLD	NEW