ui/gfx/mojo/traits_test_service.mojom - Issue 2026333002: Implement gfx::Transform StructTraits unit test

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/gfx/mojo/traits_test_service.mojom

Issue 2026333002: Implement gfx::Transform StructTraits unit test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix diff Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module gfx.mojom;	5 module gfx.mojom;

6	6

7 // See ui/gfx/transform.h.	7 import "ui/gfx/mojo/transform.mojom";

8 struct Transform {	8

9 // Row major order.	9 interface TraitsTestService {
	sadrul 2016/06/01 16:17:38 I think if you make this [Sync], then you don't ne I think if you make this [Sync], then you don't need the lambda/capture? Fady Samuel 2016/06/01 16:20:19 Making it sync on one thread would deadlock I thin Show quoted text On 2016/06/01 16:17:38, sadrul wrote: > I think if you make this [Sync], then you don't need the lambda/capture? Making it sync on one thread would deadlock I think. yzshen1 2016/06/01 16:22:24 If you mean the sender and the receiver on the sam Show quoted text On 2016/06/01 16:20:19, Fady Samuel wrote: > On 2016/06/01 16:17:38, sadrul wrote: > > I think if you make this [Sync], then you don't need the lambda/capture? > > Making it sync on one thread would deadlock I think. If you mean the sender and the receiver on the same thread, it won't deadlock. Sync services will be able to reenter any ongoing sync calls on the same thread. Fady Samuel 2016/06/01 16:32:31 Cool! I just tried it and it works and simplifies Show quoted text On 2016/06/01 16:22:24, yzshen1 wrote: > On 2016/06/01 16:20:19, Fady Samuel wrote: > > On 2016/06/01 16:17:38, sadrul wrote: > > > I think if you make this [Sync], then you don't need the lambda/capture? > > > > Making it sync on one thread would deadlock I think. > > If you mean the sender and the receiver on the same thread, it won't deadlock. > > Sync services will be able to reenter any ongoing sync calls on the same thread. Cool! I just tried it and it works and simplifies the unit test! w00t! I should go back and update the other unit tests at some point.
10 array<float, 16> matrix;	10 EchoTransform(Transform t) => (Transform pass);

11 };	11 };

OLD	NEW

« no previous file with comments | « ui/gfx/mojo/struct_traits_unittest.cc ('k') | ui/gfx/test/DEPS » ('j') | no next file with comments »