Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 202633009: Add Element::subResourceAttributeName() virtual function (Closed)

Created:
6 years, 9 months ago by Inactive
Modified:
6 years, 9 months ago
Reviewers:
tkent, adamk
CC:
blink-reviews, gavinp+prerender_chromium.org, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, rwlbuis
Visibility:
Public.

Description

Add Element::subResourceAttributeName() virtual function Add Element::subResourceAttributeName() virtual function to distribute the code to each HTML class, instead of having a complex function with a lot of branching to determine the subresource attribute name of an Element. R=tkent, adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169558

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use nullQName() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -30 lines) Patch
M Source/core/dom/Element.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/html/HTMLBodyElement.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLBodyElement.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/html/HTMLEmbedElement.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLEmbedElement.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/html/HTMLImageElement.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLImageElement.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/html/HTMLInputElement.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/html/HTMLLinkElement.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLLinkElement.cpp View 1 1 chunk +11 lines, -0 lines 0 comments Download
M Source/core/html/HTMLModElement.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLModElement.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/html/HTMLObjectElement.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLObjectElement.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/html/HTMLQuoteElement.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLQuoteElement.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/html/HTMLScriptElement.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLScriptElement.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/html/HTMLTableCellElement.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLTableCellElement.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/html/HTMLTableElement.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLTableElement.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/html/HTMLTableRowElement.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLTableRowElement.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/html/forms/ImageInputType.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/forms/ImageInputType.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/html/forms/InputType.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/forms/InputType.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/web/WebPageSerializer.cpp View 1 1 chunk +3 lines, -30 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Inactive
6 years, 9 months ago (2014-03-18 15:24:07 UTC) #1
tkent
lgtm https://codereview.chromium.org/202633009/diff/1/Source/core/dom/Element.cpp File Source/core/dom/Element.cpp (right): https://codereview.chromium.org/202633009/diff/1/Source/core/dom/Element.cpp#newcode1076 Source/core/dom/Element.cpp:1076: return 0; nit: We may return WebCore::nullQName(), or ...
6 years, 9 months ago (2014-03-19 01:00:44 UTC) #2
Inactive
https://codereview.chromium.org/202633009/diff/1/Source/core/dom/Element.cpp File Source/core/dom/Element.cpp (right): https://codereview.chromium.org/202633009/diff/1/Source/core/dom/Element.cpp#newcode1076 Source/core/dom/Element.cpp:1076: return 0; On 2014/03/19 01:00:44, tkent wrote: > nit: ...
6 years, 9 months ago (2014-03-19 13:51:42 UTC) #3
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 9 months ago (2014-03-19 13:52:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/202633009/20001
6 years, 9 months ago (2014-03-19 13:52:06 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 15:58:34 UTC) #6
Message was sent while issue was closed.
Change committed as 169558

Powered by Google App Engine
This is Rietveld 408576698