printing/cups_config_helper.py - Issue 202633008: Fix linker warning on build with target_arch=ia32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: printing/cups_config_helper.py

Issue 202633008: Fix linker warning on build with target_arch=ia32. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: printing/cups_config_helper.py

diff --git a/printing/cups_config_helper.py b/printing/cups_config_helper.py

index 3fe5fe04e1abd4e7292d818ec028f50c8031f252..cb6751e5c2fbdf26f60fc351287bc6ed3f392236 100755

--- a/printing/cups_config_helper.py

+++ b/printing/cups_config_helper.py

@@ -46,6 +46,11 @@ def run_cups_config(mode):

if flag_mode is None or flag_mode == mode:

flags_subset.append(flag)

+ # Note: cross build is sometimes confused by the option, and may trigger

satorux1 2014/03/20 08:06:10 drop "sometimes"? this issue is deterministic when

hidehiko 2014/03/21 21:36:25 Done.

+ # linker warning causing build error.

+ if '-lgnutls' in flags_subset:

+ flags_subset.remove('-lgnutls')

return flags_subset

« no previous file with comments | « build/linux/system.gyp ('k') | no next file » | no next file with comments »