Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 202633008: Fix linker warning on build with target_arch=ia32. (Closed)

Created:
6 years, 9 months ago by hidehiko
Modified:
6 years, 9 months ago
Reviewers:
gene, satorux1, gene1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix linker warning on build with target_arch=ia32. Since r257419, linker warning starts to cause the build failure. This CL is fixing some linker warnings on cross compilation build so that build with target_arch=ia32 option works properly. Here are the error logs: /usr/bin/ld: skipping incompatible /lib/x86_64-linux-gnu/libgcrypt.so when searching for -lgcrypt /usr/bin/ld: skipping incompatible /lib/x86_64-linux-gnu/libgcrypt.a when searching for -lgcrypt /usr/bin/ld: skipping incompatible /lib/x86_64-linux-gnu/libcap.so when searching for -lcap /usr/bin/ld: skipping incompatible /lib/x86_64-linux-gnu/libcap.a when searching for -lcap /usr/bin/ld: warning: libgnutls.so.26, needed by /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../lib32/libcups.so, may conflict with libgnutls.so.28 BUG=n/a TEST=build with GYP_DEFINES=target_arch=ia32, run trybot. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259463

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 2

Patch Set 3 : rebase #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M build/linux/system.gyp View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M printing/cups_config_helper.py View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
satorux1
https://codereview.chromium.org/202633008/diff/1/build/linux/system.gyp File build/linux/system.gyp (right): https://codereview.chromium.org/202633008/diff/1/build/linux/system.gyp#newcode744 build/linux/system.gyp:744: '<!@(libgcrypt-config --libs | sed -e \'s/-L[^ ]*//\')', please add ...
6 years, 9 months ago (2014-03-20 01:55:10 UTC) #1
hidehiko
Hello Gene, could you take a look into this CL? It seems some .gyp configure ...
6 years, 9 months ago (2014-03-20 07:55:08 UTC) #2
satorux1
Could you include the link error log in the patch description for the record? That'd ...
6 years, 9 months ago (2014-03-20 08:06:10 UTC) #3
gene1
Hi Hidehiko, Sorry for delay, are you still waiting for me to take a look? ...
6 years, 9 months ago (2014-03-21 18:31:18 UTC) #4
hidehiko
Yes, I'd like to ask you to review. Thanks in advance. https://codereview.chromium.org/202633008/diff/20001/printing/cups_config_helper.py File printing/cups_config_helper.py (right): ...
6 years, 9 months ago (2014-03-21 21:36:25 UTC) #5
satorux1
Ping. gene@, could you take a look? This is blocking a project that hidehiko@ and ...
6 years, 9 months ago (2014-03-25 09:29:13 UTC) #6
gene
lgtm sorry, missed previous ping.
6 years, 9 months ago (2014-03-25 17:21:58 UTC) #7
hidehiko
The CQ bit was checked by hidehiko@chromium.org
6 years, 9 months ago (2014-03-25 17:25:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/202633008/60001
6 years, 9 months ago (2014-03-25 17:25:41 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 19:53:54 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 9 months ago (2014-03-25 19:53:55 UTC) #11
hidehiko
The CQ bit was checked by hidehiko@chromium.org
6 years, 9 months ago (2014-03-26 01:01:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/202633008/60001
6 years, 9 months ago (2014-03-26 01:01:44 UTC) #13
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 04:00:20 UTC) #14
Message was sent while issue was closed.
Change committed as 259463

Powered by Google App Engine
This is Rietveld 408576698