Use an unsigned of flags in ElementRareData

Use an unsigned of flags in ElementRareData

Instead of exposing tons of getters and setters on Element we can use an
enum of flags and treat the bits inside ElementRareData as just a flag
field like we do in Node. This removes a lot of boilerplate code and also
makes the check for style sharing a lot simpler since now we can just
OR the flags that disable sharing together. That's good since that check
is super hot in profiles.

This also lets us make all the other "flag reading" methods into simple
inline getters that call hasElementFlag() which early outs on not having
any rare data.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169426

[esprehn, 2014-03-18 01:50:41]

Delete so much code!

[eseidel, 2014-03-18 03:12:20]

lgtm

https://codereview.chromium.org/202633006/diff/20001/Source/core/dom/ElementR...
File Source/core/dom/ElementRareData.h (left):

https://codereview.chromium.org/202633006/diff/20001/Source/core/dom/ElementR...
Source/core/dom/ElementRareData.h:165: // We optimize for :first-child and
:last-child. The other positional child selectors like nth-child or
Do we want to move thsi comment to the new enum?

[esprehn, 2014-03-18 03:40:49]

On 2014/03/18 03:12:20, eseidel wrote:
> lgtm
> 
>
https://codereview.chromium.org/202633006/diff/20001/Source/core/dom/ElementR...
> File Source/core/dom/ElementRareData.h (left):
> 
>
https://codereview.chromium.org/202633006/diff/20001/Source/core/dom/ElementR...
> Source/core/dom/ElementRareData.h:165: // We optimize for :first-child and
> :last-child. The other positional child selectors like nth-child or
> Do we want to move thsi comment to the new enum?

I'm not sure that's the right place to put a comment about that, I'd rather
expand the comment a near the checks. I'm also not sure this comment is right
anymore...

[esprehn, 2014-03-18 03:41:05]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-03-18 03:41:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/202633006/20001

[commit-bot: I haz the power, 2014-03-18 03:49:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-18 03:49:49]

Try jobs failed on following builders:
  tryserver.blink on mac_blink_rel

[esprehn, 2014-03-18 06:30:34]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-03-18 06:30:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/202633006/40001

[commit-bot: I haz the power, 2014-03-18 06:34:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-18 06:34:08]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[esprehn, 2014-03-18 06:36:46]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-03-18 06:36:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/202633006/40001

[commit-bot: I haz the power, 2014-03-18 06:39:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-18 06:39:38]

Try jobs failed on following builders:
  tryserver.blink on mac_blink_compile_dbg

[esprehn, 2014-03-18 06:42:32]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-03-18 06:42:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/202633006/60001

[commit-bot: I haz the power, 2014-03-18 07:49:09]

Change committed as 169426