src/compiler/unwinding-info-writer.h - Issue 2026313002: Emit unwinding information for TurboFan code.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/compiler/unwinding-info-writer.h

Issue 2026313002: Emit unwinding information for TurboFan code. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@eh-frame

Patch Set: Clarify assumptions on frame ction/dtion routines in arm/arm64. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« src/compiler/arm64/unwinding-info-writer-arm64.cc ('K') | « src/compiler/s390/unwinding-info-writer-s390.h ('k') | src/compiler/x64/code-generator-x64.cc » ('j') | src/compiler/x64/code-generator-x64.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 the V8 project authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef V8_COMPILER_UNWINDING_INFO_WRITER_H_

	6 #define V8_COMPILER_UNWINDING_INFO_WRITER_H_

	7

	8 #if V8_TARGET_ARCH_ARM

	9 #include "src/compiler/arm/unwinding-info-writer-arm.h"

	10 #elif V8_TARGET_ARCH_ARM64

	11 #include "src/compiler/arm64/unwinding-info-writer-arm64.h"

	12 #elif V8_TARGET_ARCH_IA32

	13 #include "src/compiler/ia32/unwinding-info-writer-ia32.h"
	Jarin 2016/07/06 07:09:42 Instead of including the same unimplemented unwind Instead of including the same unimplemented unwinding info writers here, could not you just put the unimplemented version of the class here and only include the headers with the real implementations? Or do you intend to implement all/most of the remaining architectures soon? Stefano Sanfilippo 2016/07/06 13:25:10 This was initially meant to be a placeholder, but Show quoted text On 2016/07/06 07:09:42, Jarin wrote: > Instead of including the same unimplemented unwinding info writers here, could > not you just put the unimplemented version of the class here and only include > the headers with the real implementations? Or do you intend to implement > all/most of the remaining architectures soon? This was initially meant to be a placeholder, but on a second thought it's better to follow your suggestion, since Linux perf presently appears to only support x64, arm, arm64 and ia32 anyway.
	14 #elif V8_TARGET_ARCH_MIPS

	15 #include "src/compiler/mips/unwinding-info-writer-mips.h"

	16 #elif V8_TARGET_ARCH_MIPS64

	17 #include "src/compiler/mips64/unwinding-info-writer-mips64.h"

	18 #elif V8_TARGET_ARCH_S390

	19 #include "src/compiler/s390/unwinding-info-writer-s390.h"

	20 #elif V8_TARGET_ARCH_X64

	21 #include "src/compiler/x64/unwinding-info-writer-x64.h"

	22 #elif V8_TARGET_ARCH_X87

	23 #include "src/compiler/x87/unwinding-info-writer-x87.h"

	24 #endif

	25

	26 #endif

OLD	NEW