Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3373)

Unified Diff: appengine/findit/waterfall/test/start_try_job_on_demand_pipeline_test.py

Issue 2026283002: [Findit] Adding logic to force try jobs regardless of bailout or previous results (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Addressing comments and rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/test/start_try_job_on_demand_pipeline_test.py
diff --git a/appengine/findit/waterfall/test/start_try_job_on_demand_pipeline_test.py b/appengine/findit/waterfall/test/start_try_job_on_demand_pipeline_test.py
index 12ca4631b42977f28fda7473142044723842abae..cea361ca09159d9926bcbb268d86d235cb866913 100644
--- a/appengine/findit/waterfall/test/start_try_job_on_demand_pipeline_test.py
+++ b/appengine/findit/waterfall/test/start_try_job_on_demand_pipeline_test.py
@@ -5,7 +5,6 @@
from testing_utils import testing
from common.pipeline_wrapper import pipeline_handlers
-from common.waterfall import failure_type
from model.wf_analysis import WfAnalysis
from waterfall import try_job_util
from waterfall.start_try_job_on_demand_pipeline import (
@@ -26,7 +25,7 @@ class StartTryJobOnDemandPipelineTest(testing.AppengineTestCase):
requests = []
self._MockTryJobScheduling(requests)
pipeline = StartTryJobOnDemandPipeline()
- self.assertFalse(pipeline.run(None, None, False, None))
+ self.assertFalse(pipeline.run(None, None, False, False, None))
self.assertEqual(0, len(requests))
def testTryJobScheduled(self):
@@ -42,7 +41,7 @@ class StartTryJobOnDemandPipelineTest(testing.AppengineTestCase):
self._MockTryJobScheduling(requests)
pipeline = StartTryJobOnDemandPipeline()
- self.assertTrue(pipeline.run(failure_info, None, True, None))
+ self.assertTrue(pipeline.run(failure_info, None, True, False, None))
self.assertEqual(1, len(requests))
self.assertEqual(
{'compile': 'try-job-key'},

Powered by Google App Engine
This is Rietveld 408576698